Support named arguments for dynamic calls.

frog/leg/ssa/builder.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 class Interceptors {
   Compiler compiler;
   Interceptors(Compiler this.compiler);
 
   SourceString mapOperatorToMethodName(Operator op) {
     String name = op.source.stringValue;
@@ skipping 869 matching lines @@
       var left = pop();
       visitBinary(left, op, right);
     }
   }
 
   void addDynamicSendArgumentsToList(Send node, List<HInstruction> list) {
     Selector selector = elements.getSelector(node);
     if (selector.namedArgumentCount == 0) {
       addGenericSendArgumentsToList(node.arguments, list);
     } else {
-      compiler.cancel(
-          'Unimplemented named argument for dynamic sends', node: node);
+      // Visit positional arguments and add them to the list.
+      Link<Node> arguments = node.arguments;
+      int positionalArgumentCount = selector.positionalArgumentCount;
+      for (int i = 0;
+           i < positionalArgumentCount;
+           arguments = arguments.tail, i++) {
+        visit(arguments.head);
+        list.add(pop());
+      }
+
+      // Visit named arguments and add them into a temporary map.
+      Map<SourceString, HInstruction> instructions =
+          new Map<SourceString, HInstruction>();
+      List<SourceString> namedArguments = selector.namedArguments;
+      int nameIndex = 0;
+      for (; !arguments.isEmpty(); arguments = arguments.tail) {
+        visit(arguments.head);
+        instructions[namedArguments[nameIndex++]] = pop();
+      }
+
+      // Iterate through the named arguments to add them to the list
+      // of instructions, in the order set by the map.
+      List<SourceString> keys = instructions.getKeys();
+      for (SourceString name in keys) {
+        list.add(instructions[name]);
+      }
+
+      // Update the selector with an ordered list of named arguments.
+      selector.orderedNamedArguments = keys;

[floitsch, 2012/02/01 12:19:17]

Why/how is keys ordered?

[ngeoffray, 2012/02/01 13:02:40]

As discussed, ordered it in another way.

     }
   }
 
   void addStaticSendArgumentsToList(Send node,
                                     FunctionElement element,
                                     List<HInstruction> list) {
     Selector selector = elements.getSelector(node);
     if (!selector.applies(compiler, element)) {
       // TODO(ngeoffray): Match the VM behavior and throw an
       // exception at runtime.
@@ skipping 600 matching lines @@
   }
 
   visitCatchBlock(CatchBlock node) {
     compiler.unimplemented('SsaBuilder.visitCatchBlock', node: node);
   }
 
   visitTypedef(Typedef node) {
     compiler.unimplemented('SsaBuilder.visitTypedef', node: node);
   }
 }