Issue 9316020: Disable unit_tests for memcheck/Mac by checking in chrome_tests.py

Issue 9316020: Disable unit_tests for memcheck/Mac by checking in chrome_tests.py (Closed)

Created:
8 years, 10 months ago by Brad Chen

Modified:
8 years, 10 months ago

Reviewers:
Lei Zhang

CC:
chromium-reviews, Timur Iskhodzhanov, Alexander Potapenko, pam+watch_chromium.org, stuartmorgan+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Disable unit_tests for memcheck/Mac by checking in chrome_tests.py Undo attempt to disable from unit_tests.gtest_mac.txt as it didn't solve the problem. BUG=51716 TEST=Chromium Mac (Valgrind)(1) bot Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=120039

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebase #

Patch Set 3 : Fix comment #

Patch Set 4 : fix copyright #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -7 lines)			Patch
	M	tools/valgrind/chrome_tests.py	View	1 2 3	2 chunks	+7 lines, -1 line	0 comments	Download
	M	tools/valgrind/gtest_exclude/unit_tests.gtest_mac.txt	View		1 chunk	+0 lines, -6 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Lei Zhang

lgtm http://codereview.chromium.org/9316020/diff/1/tools/valgrind/chrome_tests.py File tools/valgrind/chrome_tests.py (right): http://codereview.chromium.org/9316020/diff/1/tools/valgrind/chrome_tests.py#newcode284 tools/valgrind/chrome_tests.py:284: # crbug 51716 nit: can you do http://crbug.com/51716 ...

8 years, 10 months ago (2012-02-01 01:51:57 UTC) #2

Brad Chen

Thanks. will wait for a trybot run... http://codereview.chromium.org/9316020/diff/1/tools/valgrind/chrome_tests.py File tools/valgrind/chrome_tests.py (right): http://codereview.chromium.org/9316020/diff/1/tools/valgrind/chrome_tests.py#newcode284 tools/valgrind/chrome_tests.py:284: # crbug ...

8 years, 10 months ago (2012-02-01 02:02:50 UTC) #3

Alexander Potapenko

Hi all, The main problem with bug 51716 is that is not reproducible anywhere but ...

8 years, 10 months ago (2012-02-01 09:01:08 UTC) #4

Timur Iskhodzhanov

FTR, Before the chrome_tests.py change it was possible to manually run one given test by ...

8 years, 10 months ago (2012-02-01 09:14:58 UTC) #5

Brad Chen

8 years, 10 months ago (2012-02-01 14:05:48 UTC) #6

I'm not particularly attached to my change so if you see a better way of
doing this please go for it! Before this approach I tried adding "*" and
"*.*" in the gtest_exclude/unit_tests.gtest_mac.txt; that did not prevent
the failure.

Brad

On Wed, Feb 1, 2012 at 1:14 AM, Timur Iskhodzhanov <timurrrr@chromium.org>wrote:

> FTR,
> Before the chrome_tests.py change it was possible to manually run one given
> test by typing --gtest_filter=Test.Name
>
> On Wed, Feb 1, 2012 at 1:01 PM, Alexander Potapenko <glider@chromium.org>
> wrote:
> > Hi all,
> >
> > The main problem with bug 51716 is that is not reproducible anywhere
> > but on the bots, so it's good to have an opportunity to run them with
> > little local changes.
> >
> > On Wed, Feb 1, 2012 at 6:02 AM,  <bradchen@google.com> wrote:
> >> Thanks.
> >> will wait for a trybot run...
> >>
> >>
> >>
> >>
> http://codereview.chromium.org/9316020/diff/1/tools/valgrind/chrome_tests.py
> >> File tools/valgrind/chrome_tests.py (right):
> >>
> >>
>
http://codereview.chromium.org/9316020/diff/1/tools/valgrind/chrome_tests.py#...
> >> tools/valgrind/chrome_tests.py:284: # crbug 51716
> >> On 2012/02/01 01:51:57, Lei Zhang wrote:
> >>>
> >>> nit: can you do http://crbug.com/51716 ?
> >>
> >>
> >> Done.
> >>
> >> http://codereview.chromium.org/9316020/
> >
> >
> >
> > --
> > Alexander Potapenko
> > Software Engineer
> > Google Moscow
>

Expand Messages | Collapse Messages