Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6989)

Unified Diff: chrome/installer/setup/install_worker.cc

Issue 9316007: Remove wow_helper.exe from Win 7 and higher. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/setup/install_worker.cc
diff --git a/chrome/installer/setup/install_worker.cc b/chrome/installer/setup/install_worker.cc
index 73fb098258743ef5f65c9cf0c613bcf22ac56e79..b52db1ddd2fe248d778f998ba6c7d92f2e1ed4cd 100644
--- a/chrome/installer/setup/install_worker.cc
+++ b/chrome/installer/setup/install_worker.cc
@@ -753,8 +753,10 @@ void AddInstallWorkItems(const InstallationState& original_state,
// Extra executable for 64 bit systems.
// NOTE: We check for "not disabled" so that if the API call fails, we play it
// safe and copy the executable anyway.
+ // NOTE: the file wow_helper.exe is only needed for Vista and below.
if (base::win::OSInfo::GetInstance()->wow64_status() !=
- base::win::OSInfo::WOW64_DISABLED) {
+ base::win::OSInfo::WOW64_DISABLED &&
+ base::win::GetVersion() <= base::win::VERSION_VISTA) {
grt (UTC plus 2) 2012/01/31 21:27:56 I think you're about to shave a yak. Server 2008
arthurhsu 2012/01/31 22:07:35 Please refer to Ricardo's reply. BTW, I copied th
grt (UTC plus 2) 2012/02/01 02:12:17 Cool, thanks for the confirmation, Ricardo.
install_list->AddMoveTreeWorkItem(
src_path.Append(installer::kWowHelperExe).value(),
target_path.Append(installer::kWowHelperExe).value(),
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698