Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Unified Diff: chrome/browser/extensions/webstore_installer.cc

Issue 9316004: Move common file path related methods between chrome & content to file_util. I reduced the 4 meth... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: remove includes Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/download/download_util.cc ('k') | chrome/browser/web_applications/web_app.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/webstore_installer.cc
===================================================================
--- chrome/browser/extensions/webstore_installer.cc (revision 119906)
+++ chrome/browser/extensions/webstore_installer.cc (working copy)
@@ -25,7 +25,6 @@
#include "chrome/common/chrome_switches.h"
#include "chrome/common/extensions/extension.h"
#include "chrome/common/extensions/extension_constants.h"
-#include "content/browser/download/download_file.h"
#include "content/browser/download/download_types.h"
#include "content/public/browser/browser_thread.h"
#include "content/public/browser/download_manager.h"
@@ -37,7 +36,6 @@
#include "net/base/escape.h"
using content::BrowserThread;
-using content::DownloadFile;
using content::NavigationController;
namespace {
@@ -102,9 +100,9 @@
FilePath file = directory.AppendASCII(id + "_" + random_number + ".crx");
- int uniquifier = DownloadFile::GetUniquePathNumber(file);
+ int uniquifier = file_util::GetUniquePathNumber(file, FILE_PATH_LITERAL(""));
if (uniquifier > 0)
- DownloadFile::AppendNumberToPath(&file, uniquifier);
+ file = file.InsertBeforeExtensionASCII(StringPrintf(" (%d)", uniquifier));
BrowserThread::PostTask(BrowserThread::UI, FROM_HERE,
base::Bind(callback, file));
« no previous file with comments | « chrome/browser/download/download_util.cc ('k') | chrome/browser/web_applications/web_app.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698