Move common file path related methods between chrome & content to file_util. I reduced the 4 meth...

Move common file path related methods between chrome & content to file_util. I reduced the 4 methods into 3 by only having one GetUniquePathNumber which takes an optional suffix.

BUG=98716
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=119984

[Evan Martin, 2012-01-31 21:23:44]

http://codereview.chromium.org/9316004/diff/2004/base/file_util.cc
File base/file_util.cc (right):

http://codereview.chromium.org/9316004/diff/2004/base/file_util.cc#newcode248
base/file_util.cc:248: int GetUniquePathNumber(
Should this be in the anon namespace?

http://codereview.chromium.org/9316004/diff/2004/base/file_util.cc#newcode308
base/file_util.cc:308: suffix.c_str());
Simpler:

return FilePath(path.value() + suffix)

in fact, with that in mind, maybe it should be up to the caller to do this.

http://codereview.chromium.org/9316004/diff/2004/base/file_util.h
File base/file_util.h (right):

http://codereview.chromium.org/9316004/diff/2004/base/file_util.h#newcode71
base/file_util.h:71: const FilePath::StringType& suffix);
Why does one of these take a FilePath* and the other return a new FilePath?  I
think they both should behave like hte latter.

[jam, 2012-01-31 21:54:29]

http://codereview.chromium.org/9316004/diff/2004/base/file_util.cc
File base/file_util.cc (right):

http://codereview.chromium.org/9316004/diff/2004/base/file_util.cc#newcode248
base/file_util.cc:248: int GetUniquePathNumber(
On 2012/01/31 21:23:44, Evan Martin wrote:
> Should this be in the anon namespace?

no it's in the header, it's used by a few places

http://codereview.chromium.org/9316004/diff/2004/base/file_util.cc#newcode308
base/file_util.cc:308: suffix.c_str());
On 2012/01/31 21:23:44, Evan Martin wrote:
> Simpler:
> 
> return FilePath(path.value() + suffix)
> 
> in fact, with that in mind, maybe it should be up to the caller to do this.

good point, done!

also same for AppendNumberToPath, I figured it's just a one liner so I made
callers do it.

[Evan Martin, 2012-01-31 21:59:06]

LGTM