client/html/src/XMLElementWrappingImplementation.dart - Issue 9315061: Specify the types for Element.classes, Element.elements and Node.nodes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: client/html/src/XMLElementWrappingImplementation.dart

Issue 9315061: Specify the types for Element.classes, Element.elements and Node.nodes (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Fixed dynamic type error issue with VM. Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « client/html/src/XMLDocumentWrappingImplementation.dart ('k') | compiler/java/com/google/dart/compiler/resolver/Elements.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: client/html/src/XMLElementWrappingImplementation.dart

diff --git a/client/html/src/XMLElementWrappingImplementation.dart b/client/html/src/XMLElementWrappingImplementation.dart

index 161cdbf7c5e11b4cca5ad0c6aecd4bf1d5ca0659..abc39a82e5897a57b6f26da1b9d3b583d3735c25 100644

--- a/client/html/src/XMLElementWrappingImplementation.dart

+++ b/client/html/src/XMLElementWrappingImplementation.dart

@@ -43,8 +43,7 @@ class XMLElementWrappingImplementation extends ElementWrappingImplementation

return _elements;

}

- // TODO: The type of value should be Collection<Element>. See http://b/5392897

- void set elements(value) {

+ void set elements(Collection<Element> value) {

final elements = this.elements;

elements.clear();

elements.addAll(value);