Issue 9315055: merge-to-branch.sh should correctly handle added/deleted files

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9315055: merge-to-branch.sh should correctly handle added/deleted files (Closed)

Created:
8 years, 10 months ago by danno

Modified:
8 years, 10 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

merge-to-branch.sh should correctly handle added/deleted files R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=10592

Patch Set 1 #

Total comments: 2

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -2 lines)			Patch
	M	tools/merge-to-branch.sh	View		1 chunk	+16 lines, -2 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

LGTM with a nit. https://chromiumcodereview.appspot.com/9315055/diff/1/tools/merge-to-branch.sh File tools/merge-to-branch.sh (right): https://chromiumcodereview.appspot.com/9315055/diff/1/tools/merge-to-branch.sh#newcode241 tools/merge-to-branch.sh:241: [[ $? -eq 0 ]] ...

8 years, 10 months ago (2012-02-02 13:45:54 UTC) #2

danno

8 years, 10 months ago (2012-02-07 22:51:37 UTC) #3

Landed

http://codereview.chromium.org/9315055/diff/1/tools/merge-to-branch.sh
File tools/merge-to-branch.sh (right):

http://codereview.chromium.org/9315055/diff/1/tools/merge-to-branch.sh#newcod...
tools/merge-to-branch.sh:241: [[ $? -eq 0 ]] || die "Applying the patch to trunk
failed."
On 2012/02/02 13:45:54, Jakob wrote:
> Your previous error message was more fitting (or use a compromise, "Applying
the
> patch for $HASH to $MERGE_TO_BRANCH failed.")

Done.

Expand Messages | Collapse Messages