Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1044)

Unified Diff: dart/frog/leg/emitter.dart

Issue 9315028: Support default values for optional parameters. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/
Patch Set: '' Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dart/frog/leg/compiler.dart ('k') | dart/frog/leg/resolver.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/frog/leg/emitter.dart
===================================================================
--- dart/frog/leg/emitter.dart (revision 3790)
+++ dart/frog/leg/emitter.dart (working copy)
@@ -47,6 +47,7 @@
assert(selector.namedArgumentCount == 0);
return;
}
+ CompileTimeConstantHandler constants = compiler.compileTimeConstantHandler;
List<SourceString> names = selector.getOrderedNamedArguments();
String invocationName =
@@ -106,8 +107,7 @@
argumentsBuffer[count] = jsName;
parametersBuffer[selector.positionalArgumentCount + index] = jsName;
} else {
- // TODO(ngeoffray): Get the default value.
- argumentsBuffer[count] = '(void 0)';
+ argumentsBuffer[count] = constants.getJsCodeForVariable(element);
}
}
count++;
@@ -267,7 +267,7 @@
if (!staticNonFinalFields.isEmpty()) buffer.add('\n');
for (Element element in staticNonFinalFields) {
buffer.add(' this.${namer.getName(element)} = ');
- constants.emitJsCodeForField(element, buffer);
+ buffer.add(constants.getJsCodeForVariable(element));
buffer.add(';\n');
}
}
@@ -278,7 +278,7 @@
constants.getStaticFinalFieldsForEmission();
for (VariableElement element in staticFinalFields) {
buffer.add('${namer.isolatePropertyAccess(element)} = ');
- constants.emitJsCodeForField(element, buffer);
+ buffer.add(constants.getJsCodeForVariable(element));
buffer.add(';\n');
}
}
« no previous file with comments | « dart/frog/leg/compiler.dart ('k') | dart/frog/leg/resolver.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698