Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: client/html/src/DOMWrapperBase.dart

Issue 9315026: Cleanup mdn scripts (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Code review fixes Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « client/html/release/htmlimpl.dart ('k') | utils/apidoc/apidoc.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: client/html/src/DOMWrapperBase.dart
diff --git a/client/html/src/DOMWrapperBase.dart b/client/html/src/DOMWrapperBase.dart
index 8cf063c3673d8a7c3c2116d549000a1f3bd70b98..bdc2524e5f0d91b8d3c2d313956412cda5fab3e0 100644
--- a/client/html/src/DOMWrapperBase.dart
+++ b/client/html/src/DOMWrapperBase.dart
@@ -7,7 +7,11 @@ class DOMWrapperBase {
DOMWrapperBase._wrap(this._ptr) {
// We should never be creating duplicate wrappers.
- assert(_ptr.dartObjectLocalStorage === null);
+ // TODO(jacobr): this boolean value is evaluated outside of the assert
+ // to work around a mysterious and flaky bug in tip of trunk versions of
+ // chrome.
+ bool hasExistingWrapper = _ptr.dartObjectLocalStorage === null;
+ assert(hasExistingWrapper);
_ptr.dartObjectLocalStorage = this;
}
}
« no previous file with comments | « client/html/release/htmlimpl.dart ('k') | utils/apidoc/apidoc.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698