chrome/browser/extensions/api/declarative/declarative_api_constants.cc - Issue 9315010: RulesRegistry for declarative APIs.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/extensions/api/declarative/declarative_api_constants.cc

Issue 9315010: RulesRegistry for declarative APIs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Implemented ID and priority generation Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "chrome/browser/extensions/api/declarative/declarative_api_constants.h"

	6

	7 namespace extension_declarative_api_constants {
	not at google - send to devlin 2012/02/02 11:59:16 namespace extensions { namespace declarative_api_c namespace extensions { namespace declarative_api_constants { ... Aaron Boodman 2012/02/02 16:28:51 We don't need these separate constants files anymo Show quoted text On 2012/02/02 11:59:16, kalman wrote: > namespace extensions { > namespace declarative_api_constants { > > ... We don't need these separate constants files anymore (unless you need them for some specific reason?). The new way is to put the constants in an anonymous namespace in the cc file of the API implementation. battre 2012/02/02 19:12:36 Done. Show quoted text On 2012/02/02 11:59:16, kalman wrote: > namespace extensions { > namespace declarative_api_constants { > > ... Done.
	8

	9 const char kId[] = "id";

	10 const char kConditions[] = "conditions";

	11 const char kActions[] = "actions";

	12 const char kPriority[] = "priority";

	13

	14 } // namespace extension_declarative_api_constants

OLD	NEW