Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 9315009: Enable Aura for all ChromeOS builds in Chromium. (Closed)

Created:
8 years, 10 months ago by Emmanuel Saint-loubert-Bié
Modified:
8 years, 10 months ago
CC:
chromium-reviews, DaveMoore, oshima, zel
Visibility:
Public.

Description

Enable Aura for all ChromeOS builds in Chromium. This will be landed after this: https://gerrit.chromium.org/gerrit/#change,14752 BUG=112154 TEST=build with chromeos==1 in gyp and see Aura desktop. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=120240

Patch Set 1 #

Patch Set 2 : Rectity target #

Patch Set 3 : updated target/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -26 lines) Patch
M build/all.gyp View 1 2 1 chunk +25 lines, -24 lines 0 comments Download
M build/common.gypi View 1 2 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Emmanuel Saint-loubert-Bié
Hi Ben, PTAL, I would like to submit this CL as soon as we have ...
8 years, 10 months ago (2012-01-31 20:48:43 UTC) #1
Ben Goodger (Google)
8 years, 10 months ago (2012-01-31 21:06:30 UTC) #2
LGTM

On Tue, Jan 31, 2012 at 12:48 PM, <saintlou@chromium.org> wrote:

> Reviewers: Ben Goodger (Google),
>
> Message:
>
> Hi Ben,
>
> PTAL, I would like to submit this CL as soon as we have switched things on
> the
> CrOS side.
>
> Thanks,
>
> -- Emmanuel
>
> Description:
> Enable Aura for all ChromeOS builds in Chromium.
>
> This will be landed after this: https://gerrit.chromium.org/**
> gerrit/#change,14752 <https://gerrit.chromium.org/gerrit/#change,14752>
>
> BUG=112154
> TEST=build with chromeos==1 in gyp and see Aura desktop.
>
> Please review this at
http://codereview.chromium.**org/9315009/<http://codereview.chromium.org/9315...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>  M build/common.gypi
>
>
> Index: build/common.gypi
> diff --git a/build/common.gypi b/build/common.gypi
> index f8a45ec9c0895dfbbdc4d41a2f0d34**b75f23d5e9..**
> 670daf2c507a9af10f5c7c73c10743**22bb391d24 100644
> --- a/build/common.gypi
> +++ b/build/common.gypi
> @@ -63,8 +63,8 @@
>               '<!(uname -m | sed -e "s/i.86/ia32/;s/x86_64/x64/;s/**
> amd64/x64/;s/arm.*/arm/;s/**i86pc/ia32/")',
>           }],
>
> -          # Ash requires Aura.
> -          ['use_ash==1', {
> +          # Ash and ChromeOS require Aura.
> +          ['use_ash==1 or chromeos==1', {
>             'use_aura%': 1,
>           }],
>
>
>
>

Powered by Google App Engine
This is Rietveld 408576698