Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4464)

Unified Diff: chrome/common/extensions/extension.cc

Issue 9315007: Make the Chrome Web Store Icon Syncable (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Adding check to ensure we don't download CWS Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/extension.cc
diff --git a/chrome/common/extensions/extension.cc b/chrome/common/extensions/extension.cc
index 9fc73cddc592eb3b1f50d7e7fd7359cfb470bd16..8e0eb8c7f0a8419f71f39bd14cf6a4abc014c749 100644
--- a/chrome/common/extensions/extension.cc
+++ b/chrome/common/extensions/extension.cc
@@ -2971,6 +2971,11 @@ bool Extension::OverlapsWithOrigin(const GURL& origin) const {
}
Extension::SyncType Extension::GetSyncType() const {
+ // The CWS needs to be treated as syncable app because it appears on the NTP
+ // and we need to make sure its position values are synced.
akalin 2012/02/03 01:44:43 add a note here about doing it more systematically
csharp 2012/02/03 14:57:04 Done.
+ if (id() == extension_misc::kWebStoreAppId)
+ return SYNC_TYPE_APP;
+
// TODO(akalin): Figure out if we need to allow some other types.
if (location() != Extension::INTERNAL) {
// We have a non-standard location.

Powered by Google App Engine
This is Rietveld 408576698