Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1759)

Unified Diff: chrome/browser/extensions/extension_service.cc

Issue 9315007: Make the Chrome Web Store Icon Syncable (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Fixing Spelling Mistake Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_service.cc
diff --git a/chrome/browser/extensions/extension_service.cc b/chrome/browser/extensions/extension_service.cc
index 6fe5f1eb5e33ce1b4fc0e7410b12ce650183f979..fbad60a4921e4492c16ffd974f2db756623a1532 100644
--- a/chrome/browser/extensions/extension_service.cc
+++ b/chrome/browser/extensions/extension_service.cc
@@ -1583,8 +1583,14 @@ void ExtensionService::SetIsIncognitoEnabled(
const std::string& extension_id, bool enabled) {
const Extension* extension = GetInstalledExtension(extension_id);
if (extension && extension->location() == Extension::COMPONENT) {
- // This shouldn't be called for component extensions.
- NOTREACHED();
+ // This shouldn't be called for component extensions other than the
+ // web store (which is considered an app, and may try to set this value).
+ DCHECK_EQ(extension_id, extension_misc::kWebStoreAppId);
+
+ // If we are here with the CWS, make sure the we aren't trying to
+ // change it.
+ DCHECK_EQ(enabled, IsIncognitoEnabled(extension_id));
+
return;
}

Powered by Google App Engine
This is Rietveld 408576698