Issue 9315004: Remove Owner param to EventFilter's ctor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9315004: Remove Owner param to EventFilter's ctor. (Closed)

Created:
8 years, 10 months ago by Ben Goodger (Google)

Modified:
8 years, 10 months ago

Reviewers:
sky

CC:
chromium-reviews, dhollowa+watch_chromium.org, sadrul, dcheng, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Remove Owner param to EventFilter's ctor. BUG=none TEST=existing unittests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=119954

Patch Set 1 #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+26 lines, -69 lines)			Patch
M	ash/accelerators/accelerator_filter.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	ash/app_list/app_list.cc	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	ash/drag_drop/drag_drop_controller.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	ash/ime/input_method_event_filter.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	ash/ime/input_method_event_filter_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ash/tooltips/tooltip_controller.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	ash/wm/root_window_event_filter.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	ash/wm/root_window_event_filter_unittest.cc	View	1 chunk	+2 lines, -4 lines	0 comments	Download
M	ash/wm/system_modal_container_event_filter.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	ash/wm/system_modal_container_event_filter.cc	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	ash/wm/system_modal_container_layout_manager.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ash/wm/toplevel_window_event_filter.h	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	ash/wm/toplevel_window_event_filter.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ash/wm/window_cycle_controller.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	ash/wm/window_modality_controller.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/aura/aura.gyp	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	ui/aura/event_filter.h	View	2 chunks	+1 line, -10 lines	0 comments	Download
D	ui/aura/event_filter.cc	View	1 chunk	+0 lines, -21 lines	0 comments	Download
M	ui/aura/event_filter_unittest.cc	View	1 chunk	+3 lines, -4 lines	0 comments	Download
M	ui/aura/test/test_event_filter.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/aura/test/test_event_filter.cc	View	1 chunk	+2 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Ben Goodger (Google)

This reduces (trivially) the number of callers of RootWindow::GetInstance()

8 years, 10 months ago (2012-01-31 19:26:24 UTC) #1

LGTM

Expand Messages | Collapse Messages