Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(579)

Unified Diff: runtime/vm/compiler.h

Issue 9314053: Revert Dart_PropagateError until I can track down the problems in (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/code_generator_x64_test.cc ('k') | runtime/vm/compiler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/compiler.h
===================================================================
--- runtime/vm/compiler.h (revision 3821)
+++ runtime/vm/compiler.h (working copy)
@@ -25,32 +25,21 @@
public:
// Extracts class, interface, function symbols from the script and populates
// the symbol tables and the class dictionary of the library.
- //
- // Returns Error::null() if there is no compilation error.
- static RawError* Compile(const Library& library, const Script& script);
+ static void Compile(const Library& library, const Script& script);
// Generates code for given function and sets its code field.
- //
- // Returns Error::null() if there is no compilation error.
- static RawError* CompileFunction(const Function& function);
+ static void CompileFunction(const Function& function);
// Generates optimized code for function.
- //
- // Returns Error::null() if there is no compilation error.
- static RawError* CompileOptimizedFunction(const Function& function);
+ static void CompileOptimizedFunction(const Function& function);
// Generates and executes code for a given code fragment, e.g. a
// compile time constant expression. Returns the result returned
// by the fragment.
- //
- // The return value is either a RawInstance on success or a RawError
- // on compilation failure.
- static RawObject* ExecuteOnce(SequenceNode* fragment);
+ static RawInstance* ExecuteOnce(SequenceNode* fragment);
// Eagerly compiles all functions in a class.
- //
- // Returns Error::null() if there is no compilation error.
- static RawError* CompileAllFunctions(const Class& cls);
+ static void CompileAllFunctions(const Class& cls);
};
} // namespace dart
« no previous file with comments | « runtime/vm/code_generator_x64_test.cc ('k') | runtime/vm/compiler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698