Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: tools/testing/dart/test_suite.dart

Issue 9314047: Get Firefox on Windows running. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: '' Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/language/language.status ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_suite.dart
===================================================================
--- tools/testing/dart/test_suite.dart (revision 3800)
+++ tools/testing/dart/test_suite.dart (working copy)
@@ -428,11 +428,17 @@
dartWrapperFilename : compiledDartWrapperFilename;
// Create the HTML file for the test.
RandomAccessFile htmlTest = new File(htmlPath).openSync(FileMode.WRITE);
+ String filePrefix = '';
+ if (new Platform().operatingSystem() == 'windows') {
+ // Firefox on Windows does not like absolute file path names that start
+ // with 'C:' adding 'file:///' solves the problem.
+ filePrefix = 'file:///';
+ }
htmlTest.writeStringSync(GetHtmlContents(
filename,
- '$dartDir/client/testing/unittest/test_controller.js',
+ '$filePrefix$dartDir/client/testing/unittest/test_controller.js',
scriptType,
- scriptPath));
+ filePrefix + scriptPath));
htmlTest.closeSync();
List<String> compilerArgs = TestUtils.standardOptions(configuration);
« no previous file with comments | « tests/language/language.status ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698