Issue 9314031: Make sure even if chrome crashes on login we properly populate the use_shared_proxies pref.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9314031: Make sure even if chrome crashes on login we properly populate the use_shared_proxies pref. (Closed)

Created:
8 years, 10 months ago by pastarmovj

Modified:
8 years, 10 months ago

Reviewers:
Nikita (slow), Mattias Nissler (ping if slow)

CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org, kuan, zel, xiyuan, Nikita (slow)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Make sure even if chrome crashes on login we properly populate the use_shared_proxies pref. This is necessary to enforce proper operation if the browser crashes too early in the login sequence and the preferences file has not been stored yet. BUG=chromium-os:25703 TEST=Manually tested by putting a DCHECK just after setting the pref in LoginUtilsImpl::OnProfileCreated. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=120072

Patch Set 1 #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -3 lines)			Patch
	M	chrome/browser/chromeos/chrome_browser_main_chromeos.cc	View		2 chunks	+12 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

pastarmovj

Please have a look at this appendix to the quick and dirty patch. As Nikita ...

8 years, 10 months ago (2012-02-01 12:13:47 UTC) #1

lgtm

Expand Messages | Collapse Messages