Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Issue 9314030: Set a proper first-party URL when fetching resources via ResourceFetcher (Closed)

Created:
8 years, 10 months ago by jochen (gone - plz use gerrit)
Modified:
8 years, 10 months ago
CC:
chromium-reviews, darin-cc_chromium.org
Visibility:
Public.

Description

Set a proper first-party URL when fetching resources via ResourceFetcher Otherwise, e.g. favicons will be fetched with a first party about:blank, so third-party cookie blocking rules apply, even if the favicon is hosted on the same site as the first-party BUG=none TEST=enabled 3rd party cookie blocking, go to google.com, there should be no blocked cookies Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=120219

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M webkit/glue/resource_fetcher.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jochen (gone - plz use gerrit)
Darin, plz review
8 years, 10 months ago (2012-02-01 10:48:01 UTC) #1
darin (slow to review)
LGTM
8 years, 10 months ago (2012-02-01 17:49:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/9314030/1
8 years, 10 months ago (2012-02-02 10:44:58 UTC) #3
commit-bot: I haz the power
Try job failure for 9314030-1 (retry) (retry) on win_rel for step "test_shell_tests". It's a second ...
8 years, 10 months ago (2012-02-02 13:07:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/9314030/1
8 years, 10 months ago (2012-02-02 13:48:05 UTC) #5
commit-bot: I haz the power
8 years, 10 months ago (2012-02-02 15:48:22 UTC) #6
Try job failure for 9314030-1 (retry) on win_rel for step "test_shell_tests".
It's a second try, previously, steps "test_shell_tests, safe_browsing_tests,
browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Powered by Google App Engine
This is Rietveld 408576698