Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Unified Diff: dart/tools/testing/dart/test_suite.dart

Issue 9310118: @dynamic-type-error are no longer negative tests (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dart/tests/co19/testcfg.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/tools/testing/dart/test_suite.dart
diff --git a/dart/tools/testing/dart/test_suite.dart b/dart/tools/testing/dart/test_suite.dart
index 17f99a4103cb2da4169a324fc87847de15df5565..f96273e2a67104b3fc7226a18004e24cbf1ea4fb 100644
--- a/dart/tools/testing/dart/test_suite.dart
+++ b/dart/tools/testing/dart/test_suite.dart
@@ -713,9 +713,6 @@ class StandardTestSuite implements TestSuite {
if (contents.contains("@compile-error") ||
contents.contains("@runtime-error")) {
isNegative = true;
- } else if (contents.contains("@dynamic-type-error") &&
- configuration['checked']) {
- isNegative = true;
}
bool isMultitest = multiTestRegExp.hasMatch(contents);
« no previous file with comments | « dart/tests/co19/testcfg.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698