Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Unified Diff: tests/language/language.status

Issue 9310097: skip invalid JS tests on IE as well (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/language/language.status
diff --git a/tests/language/language.status b/tests/language/language.status
index 1e1fbb10e20d222fcdf89f44779d2d052cfcfc6f..1747003efa7d6ced916afa33f818e1832ca867cf 100644
--- a/tests/language/language.status
+++ b/tests/language/language.status
@@ -227,13 +227,13 @@ ToStringAsFixedTest: Fail # fails due to rounding in constant propagation
# This set of four test components (frog, frogsh, frogium, and webdriver) all
# consume frog output, so if frog is generating the incorrect code, chances are
-# it will fail on all of these components.
+# it will fail on all of these components.
#
# Further explanation:
# frog: frog compiler, run using the VM
# frogsh: self-hosted frog compiler
# frogium: Dart code compiled with frogsh running under DumpRenderTree
-# webdriver: Dart code compiled with frogsh running on an actual browser
+# webdriver: Dart code compiled with frogsh running on an actual browser
# (Chrome, IE, Firefox, Safari, etc). If a test is only failing on a particular
# browser, you can be more specific about the failure by using $browser:
# [ $component == webdriver && $browser == chrome ] for example.
@@ -398,7 +398,10 @@ ToStringAsFixedTest: Fail
ExecuteFinally7Test: Skip
StaticFinalField2NegativeTest: Skip
-[ $component == webdriver && ($browser == ff || $browser == safari) ]
+# For these tests Frog generates invalid JS. Chrome throws a SyntaxError, but
+# other browsers don't, so they eventually timeout.
+# In any case, we shouldn't be relying on SyntaxError.
+[ $component == webdriver && ($browser == ff || $browser == safari || $browser == ie) ]
Label2NegativeTest: Skip
Label3NegativeTest: Skip
Label5NegativeTest: Skip
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698