Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: frog/leg/resolver.dart

Issue 9310066: Generate a resolution error if a unary + is used for something other than numbers. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: '' Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | frog/leg/ssa/builder.dart » ('j') | tests/language/language-leg.status » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: frog/leg/resolver.dart
===================================================================
--- frog/leg/resolver.dart (revision 3845)
+++ frog/leg/resolver.dart (working copy)
@@ -622,11 +622,17 @@
visitSend(Send node) {
Element target = resolveSend(node);
if (node.isOperator) {
- if (node.selector.asIdentifier().source.stringValue === 'is') {
+ Operator op = node.selector.asOperator();
+ if (op.source.stringValue === 'is') {
resolveTypeTest(node.arguments.head);
assert(node.arguments.tail.isEmpty());
mapping.setSelector(node, Selector.BINARY_OPERATOR);
} else if (node.arguments.isEmpty()) {
+ if (node.isPrefix && op.source.stringValue === '+'
+ && node.receiver.asLiteralInt() == null
ahe 2012/02/02 17:43:27 ===
ngeoffray 2012/02/03 08:43:46 Done.
+ && node.receiver.asLiteralDouble() == null) {
ahe 2012/02/02 17:43:27 ===
ngeoffray 2012/02/03 08:43:46 Done.
+ error(node, MessageKind.NO_UNARY_ADD);
ahe 2012/02/02 17:43:27 "expected a literal number"
ngeoffray 2012/02/03 08:43:46 Done.
+ }
mapping.setSelector(node, Selector.UNARY_OPERATOR);
} else {
visit(node.argumentsNode);
« no previous file with comments | « no previous file | frog/leg/ssa/builder.dart » ('j') | tests/language/language-leg.status » ('J')

Powered by Google App Engine
This is Rietveld 408576698