Rework Windows process handling.

runtime/bin/process_impl.dart

-// Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
+// Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 class _ProcessStartStatus {
   int _errorCode;  // Set to OS error code if process start failed.
   String _errorMessage;  // Set to OS error message if process start failed.
 }
 
 
 class _Process implements Process {
@@ skipping 67 matching lines @@
 
     // Make sure to activate socket handlers now that the file
     // descriptors have been set.
     _in._activateHandlers();
     _out._activateHandlers();
     _err._activateHandlers();
 
     // Setup an exit handler to handle internal cleanup and possible
     // callback when a process terminates.
     _exitHandler.inputStream.dataHandler = () {
-      final int EXIT_DATA_SIZE = 12;
+      final int EXIT_DATA_SIZE = 8;
       List<int> exitDataBuffer = new List<int>(EXIT_DATA_SIZE);
       int exitDataRead = 0;
 
       int exitCode(List<int> ints) {
-        var code = _intFromBytes(ints, 4);
-        var negative = _intFromBytes(ints, 8);
+        var code = _intFromBytes(ints, 0);
+        var negative = _intFromBytes(ints, 4);
         assert(negative == 0 || negative == 1);
         return (negative == 0) ? code : -code;
       }
 
-      int exitPid(List<int> ints) {
-        return _intFromBytes(ints, 0);
-      }
-
       void handleExit() {
-        _processExit(exitPid(exitDataBuffer));
         if (_exitHandlerCallback !== null) {
           _exitHandlerCallback(exitCode(exitDataBuffer));
         }
       }
 
       exitDataRead += _exitHandler.inputStream.readInto(
           exitDataBuffer, exitDataRead, EXIT_DATA_SIZE - exitDataRead);
       if (exitDataRead == EXIT_DATA_SIZE) handleExit();
     };
 
     if (_startHandler !== null) {
       _startHandler();
     }
   }
 
   bool _start(String path,
               List<String> arguments,
               String workingDirectory,
               Socket input,
               Socket output,
               Socket error,
               Socket exitHandler,
               _ProcessStartStatus status) native "Process_Start";
 
-  void _processExit(int pid) native "Process_Exit";
-
   InputStream get stdout() {
     if (_closed) {
       throw new ProcessException("Process closed");
     }
     return _in.inputStream;
   }
 
   InputStream get stderr() {
     if (_closed) {
       throw new ProcessException("Process closed");
@@ skipping 68 matching lines @@
   Socket _err;
   Socket _exitHandler;
   int _pid;
   bool _closed;
   bool _killed;
   bool _started;
   Function _exitHandlerCallback;
   Function _errorHandler;
   Function _startHandler;
 }