Revert 119948 - Support for showing/hiding status area volume controls in desktop devices.

Revert 119948 - Support for showing/hiding status area volume controls in desktop devices.

* Show status area volume control when the command line has --show-volume-status 
* Create AudioHandler::VolumeObserver class and helpers so VolumeMenuButton and VolumeControlView can observe volume changes from key presses.
* Move GetAudioHandler() common code in VolumeMenuButton and SystemKeyEventListener that returns the AudioHandler singleton only if the mixer has finished initializing to AudioHandler::GetInitialized().
* Handle mute in VolumeMenuButton correctly.

BUG=chromium-os:22080
TEST=Should see the volume control in the status area on builds with USE flag is_desktop set. The volume control icon and menu should be in sync with volume key button controls.
Review URL: https://chromiumcodereview.appspot.com/9169033

TBR=achuith@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=120019

[kinuko, 2012-02-01 03:37:10]

On 2012/02/01 03:35:06, kinuko wrote:

Hi, I'm reverting this as we suspected as we suspected it might have broken the
chromeos aura bot.  (Sorry if it was a false alarm)
http://build.chromium.org/p/chromium.chromiumos/builders/ChromiumOS%20%28aura...

[falken, 2012-02-01 03:41:51]

I suspected this broke the bot due to the stack traces here:

http://build.chromium.org/p/chromium.chromiumos/builders/ChromiumOS%20%28aura...

https://sandbox.google.com/storage/?arg=chromeos-image-archive/aura-tot-chrom...

See the *.dmp.txt files, e.g.:

Crash reason:  SIGSEGV
Crash address: 0x0

Thread 0 (crashed)
 0  chrome!chromeos::AudioHandler::RemoveVolumeObserver [audio_handler.cc : 132
+ 0x0]
    eip = 0x73c47b85   esp = 0x7fa589e0   ebp = 0x7fa58a38   ebx = 0x77927ff4
    esi = 0x00000000   edi = 0x7fa58a18   eax = 0x7fa58a0c   ecx = 0x00000000
    edx = 0x799109ec   efl = 0x00210212
    Found by: given as instruction pointer in context
 1  chrome!chromeos::VolumeMenuButton::~VolumeMenuButton [volume_menu_button.cc
: 67 + 0x4]
    eip = 0x736ee837   esp = 0x7fa58a40   ebp = 0x7fa58a58   ebx = 0x77927ff4
    esi = 0x79910800   edi = 0x789c2e00
    Found by: call frame info
 2  chrome!chromeos::VolumeMenuButton::~VolumeMenuButton [volume_menu_button.cc
: 208 + 0x7]
    eip = 0x736ee8c3   esp = 0x7fa58a60   ebp = 0x7fa58a78   ebx = 0x77927ff4
    esi = 0x79910800   edi = 0x789c2e00
    Found by: call frame info
 3  chrome!views::View::~View [view.cc : 141 + 0x7]
    eip = 0x76182ac1   esp = 0x7fa58a80   ebp = 0x7fa58ab8   ebx = 0x77927ff4
    esi = 0x799126cc   edi = 0x789c2e00
    Found by: call frame info
[...]

[achuithb, 2012-02-01 03:59:50]

On 2012/02/01 03:41:51, falken wrote:
> I suspected this broke the bot due to the stack traces here:
> 
>
http://build.chromium.org/p/chromium.chromiumos/builders/ChromiumOS%2520%2528...
> 
>
https://sandbox.google.com/storage/?arg=chromeos-image-archive/aura-tot-chrom...
> 
> See the *.dmp.txt files, e.g.:
> 
> Crash reason:  SIGSEGV
> Crash address: 0x0
> 
> Thread 0 (crashed)
>  0  chrome!chromeos::AudioHandler::RemoveVolumeObserver [audio_handler.cc :
132
> + 0x0]
>     eip = 0x73c47b85   esp = 0x7fa589e0   ebp = 0x7fa58a38   ebx = 0x77927ff4
>     esi = 0x00000000   edi = 0x7fa58a18   eax = 0x7fa58a0c   ecx = 0x00000000
>     edx = 0x799109ec   efl = 0x00210212
>     Found by: given as instruction pointer in context
>  1  chrome!chromeos::VolumeMenuButton::~VolumeMenuButton
[volume_menu_button.cc
> : 67 + 0x4]
>     eip = 0x736ee837   esp = 0x7fa58a40   ebp = 0x7fa58a58   ebx = 0x77927ff4
>     esi = 0x79910800   edi = 0x789c2e00
>     Found by: call frame info
>  2  chrome!chromeos::VolumeMenuButton::~VolumeMenuButton
[volume_menu_button.cc
> : 208 + 0x7]
>     eip = 0x736ee8c3   esp = 0x7fa58a60   ebp = 0x7fa58a78   ebx = 0x77927ff4
>     esi = 0x79910800   edi = 0x789c2e00
>     Found by: call frame info
>  3  chrome!views::View::~View [view.cc : 141 + 0x7]
>     eip = 0x76182ac1   esp = 0x7fa58a80   ebp = 0x7fa58ab8   ebx = 0x77927ff4
>     esi = 0x799126cc   edi = 0x789c2e00
>     Found by: call frame info
> [...]

Yup, that looks like me...