Issue 9310006: options: Open Google Dashboard link in a new tab

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9310006: options: Open Google Dashboard link in a new tab (Closed)

Created:
8 years, 10 months ago by Tyler Breisacher (Chromium)

Modified:
8 years, 10 months ago

Reviewers:
James Hawkins

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

options: Open Google Dashboard link in a new tab BUG=112137 TEST=sign into Chrome, open settings page, click Google Dashboard link Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=120028

Patch Set 1 #

Patch Set 2 : whitespace #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/app/generated_resources.grd	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Tyler Breisacher (Chromium)

Opening in a new tab solves this problem, and is consistent with what we do ...

8 years, 10 months ago (2012-01-31 21:57:09 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tbreisacher@chromium.org/9310006/2001

8 years, 10 months ago (2012-01-31 22:10:05 UTC) #3

commit-bot: I haz the power

Try job failure for 9310006-2001 (retry) on win_rel for step "unit_tests". It's a second try, ...

8 years, 10 months ago (2012-02-01 00:21:52 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tbreisacher@chromium.org/9310006/2001

8 years, 10 months ago (2012-02-01 00:23:40 UTC) #5

commit-bot: I haz the power

8 years, 10 months ago (2012-02-01 03:20:21 UTC) #6

Try job failure for 9310006-2001 (retry) on win_rel for steps "browser_tests,
ui_tests".
It's a second try, previously, steps "browser_tests, ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Expand Messages | Collapse Messages