Issue 9310002: Deliver NOTIFICATION_SESSION_STARTED if the browser crashes and is restarted.

Issue 9310002: Deliver NOTIFICATION_SESSION_STARTED if the browser crashes and is restarted. (Closed)

Created:
8 years, 10 months ago by flackr

Modified:
8 years, 10 months ago

Reviewers:
Nikita (slow)

CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Deliver NOTIFICATION_SESSION_STARTED if the browser crashes and is restarted. BUG=112109 TEST=Crash the browser and verify that screenlocker observers have been registered (i.e. short power press works). Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=120099

Patch Set 1 #

Total comments: 2

Patch Set 2 : Merge with master. #

Patch Set 3 : Merge with master. #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -1 line)			Patch
	M	chrome/browser/chromeos/chrome_browser_main_chromeos.cc	View	1 2	2 chunks	+6 lines, -0 lines	0 comments	Download
	M	chrome/common/chrome_notification_types.h	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

flackr

Please take a look, thanks. https://chromiumcodereview.appspot.com/9310002/diff/1/chrome/browser/chromeos/chrome_browser_main_chromeos.cc File chrome/browser/chromeos/chrome_browser_main_chromeos.cc (right): https://chromiumcodereview.appspot.com/9310002/diff/1/chrome/browser/chromeos/chrome_browser_main_chromeos.cc#newcode401 chrome/browser/chromeos/chrome_browser_main_chromeos.cc:401: content::NotificationService::NoDetails()); This was also ...

8 years, 10 months ago (2012-01-31 17:53:46 UTC) #1

Nikita (slow)

lgtm https://chromiumcodereview.appspot.com/9310002/diff/1/chrome/browser/chromeos/chrome_browser_main_chromeos.cc File chrome/browser/chromeos/chrome_browser_main_chromeos.cc (right): https://chromiumcodereview.appspot.com/9310002/diff/1/chrome/browser/chromeos/chrome_browser_main_chromeos.cc#newcode401 chrome/browser/chromeos/chrome_browser_main_chromeos.cc:401: content::NotificationService::NoDetails()); On 2012/01/31 17:53:46, flackr wrote: > This ...

8 years, 10 months ago (2012-02-01 10:38:46 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/flackr@chromium.org/9310002/1

8 years, 10 months ago (2012-02-01 16:21:30 UTC) #3

commit-bot: I haz the power

Can't apply patch for file chrome/browser/chromeos/chrome_browser_main_chromeos.cc. While running patch -p1 --forward --force; patching file chrome/browser/chromeos/chrome_browser_main_chromeos.cc ...

8 years, 10 months ago (2012-02-01 17:47:40 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/flackr@chromium.org/9310002/2003

8 years, 10 months ago (2012-02-01 19:26:58 UTC) #5

commit-bot: I haz the power

8 years, 10 months ago (2012-02-01 19:27:00 UTC) #6

Can't apply patch for file
chrome/browser/chromeos/chrome_browser_main_chromeos.cc.
While running patch -p1 --forward --force;
patching file chrome/browser/chromeos/chrome_browser_main_chromeos.cc
Hunk #1 FAILED at 50.
Hunk #2 succeeded at 388 (offset 2 lines).
1 out of 2 hunks FAILED -- saving rejects to file
chrome/browser/chromeos/chrome_browser_main_chromeos.cc.rej

Expand Messages | Collapse Messages