Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9309117: Unittest for CookieStore::DeleteAllCreatedBetweenAsync(). (Closed)

Created:
8 years, 10 months ago by droger
Modified:
8 years, 10 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, wtc, Randy Smith (Not in Mondays), darin-cc_chromium.org, rkn
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Unittest for CookieStore::DeleteAllCreatedBetweenAsync(). This method has been promoted from CookieMonster to CookieStore. This CL implements a unittest for this method, using only the CookieStore API. BUG=NONE TEST=NONE Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=120776

Patch Set 1 #

Patch Set 2 : Attempt at fixing windows build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -2 lines) Patch
M net/base/cookie_store_unittest.h View 1 3 chunks +53 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
droger
8 years, 10 months ago (2012-02-06 10:36:41 UTC) #1
erikwright (departed)
On 2012/02/06 10:36:41, droger wrote: LGTM
8 years, 10 months ago (2012-02-06 14:39:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/droger@chromium.org/9309117/1
8 years, 10 months ago (2012-02-06 15:34:35 UTC) #3
commit-bot: I haz the power
Try job failure for 9309117-1 (retry) on win_rel for step "compile" (clobber build). It's a ...
8 years, 10 months ago (2012-02-06 16:07:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/droger@chromium.org/9309117/6001
8 years, 10 months ago (2012-02-06 16:58:47 UTC) #5
commit-bot: I haz the power
Try job failure for 9309117-6001 (retry) on mac_rel for step "test_shell_tests". It's a second try, ...
8 years, 10 months ago (2012-02-06 18:38:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/droger@chromium.org/9309117/6001
8 years, 10 months ago (2012-02-06 22:13:25 UTC) #7
commit-bot: I haz the power
Try job failure for 9309117-6001 (previous was lost) (retry) on mac_rel for step "browser_tests". It's ...
8 years, 10 months ago (2012-02-07 01:16:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/droger@chromium.org/9309117/6001
8 years, 10 months ago (2012-02-07 06:20:10 UTC) #9
commit-bot: I haz the power
Try job failure for 9309117-6001 (retry) on mac_rel for steps "net_unittests, ui_tests". It's a second ...
8 years, 10 months ago (2012-02-07 08:10:11 UTC) #10
commit-bot: I haz the power
8 years, 10 months ago (2012-02-07 10:05:38 UTC) #11

Powered by Google App Engine
This is Rietveld 408576698