Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9309116: [Clean up] Fix style guide nits in chrome/browser/resources/options2. (Closed)

Created:
8 years, 10 months ago by Dan Beam
Modified:
8 years, 10 months ago
Reviewers:
csilv
CC:
chromium-reviews, tfarina, arv (Not doing code reviews), James Hawkins
Visibility:
Public.

Description

[Clean up] Fix style guide nits in chrome/browser/resources/options2. R=csilv@chromium.org TEST=No regressions, CSS follows style guide / passes presubmit. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=120750

Patch Set 1 #

Patch Set 2 : removing some only \n changes #

Patch Set 3 : rebase, only 1 conflict \o/ #

Patch Set 4 : removing browser_options.css as jhawkins made it squeaky clean #

Patch Set 5 : I take it back, removing TODO()ne. #

Patch Set 6 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+133 lines, -128 lines) Patch
M chrome/browser/resources/options2/alert_overlay.css View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/resources/options2/autofill_overlay.css View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/options2/browser_options.css View 1 2 3 4 1 chunk +2 lines, -6 lines 0 comments Download
M chrome/browser/resources/options2/certificate_manager.css View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/resources/options2/certificate_tree.css View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/resources/options2/chromeos/accounts_options_page.css View 6 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/resources/options2/chromeos/bluetooth.css View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options2/chromeos/change_picture_options.css View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options2/chromeos/internet_options_page.css View 5 chunks +14 lines, -14 lines 0 comments Download
M chrome/browser/resources/options2/chromeos/pointer_overlay.css View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/resources/options2/chromeos/proxy.css View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options2/chromeos/virtual_keyboard.css View 2 chunks +4 lines, -6 lines 0 comments Download
M chrome/browser/resources/options2/clear_browser_data_overlay.css View 1 1 chunk +3 lines, -5 lines 0 comments Download
chrome/browser/resources/options2/content_settings.css View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options2/cookies_view.css View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/options2/font_settings.css View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options2/handler_options.css View 1 4 chunks +5 lines, -7 lines 0 comments Download
M chrome/browser/resources/options2/import_data_overlay.css View 2 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/resources/options2/intents_view.css View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/options2/language_options.css View 8 chunks +27 lines, -27 lines 0 comments Download
M chrome/browser/resources/options2/manage_profile_overlay.css View 1 2 3 4 3 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/resources/options2/options_page.css View 1 2 3 4 5 12 chunks +19 lines, -19 lines 0 comments Download
M chrome/browser/resources/options2/password_manager.css View 1 2 1 chunk +1 line, -2 lines 0 comments Download
chrome/browser/resources/options2/search_engine_manager.css View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
chrome/browser/resources/options2/startup_overlay.css View 1 2 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/resources/options2/subpages_tab_controls.css View 3 chunks +9 lines, -11 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Dan Beam
8 years, 10 months ago (2012-02-06 10:29:26 UTC) #1
Dan Beam
Oh, sorry, I should mention this is just re-arranging and copyright stuff. Please just review ...
8 years, 10 months ago (2012-02-06 10:45:18 UTC) #2
csilv
lgtm
8 years, 10 months ago (2012-02-07 01:15:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/9309116/5001
8 years, 10 months ago (2012-02-07 01:22:41 UTC) #4
commit-bot: I haz the power
8 years, 10 months ago (2012-02-07 05:35:12 UTC) #5 
The commit queue went berserk retrying too often for a
seemingly flaky test. Builder is mac_rel, revision is 120677, job name
was 9309116-5001 (previous was lost) (previous was lost) (previous was lost)
(retry).

Powered by Google App Engine
This is Rietveld 408576698