Allow "internal" APIs to be specified in extension API schemas.

chrome/renderer/resources/extensions/schema_generated_bindings.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This script contains privileged chrome extension related javascript APIs.
 // It is loaded by pages whose URL has the chrome-extension protocol.
 
 var chrome = chrome || {};
 (function() {
   native function GetChromeHidden();
   native function GetExtensionAPIDefinition();
   native function GetNextRequestId();
   native function StartRequest();
   native function SetIconCommon();
 
   var chromeHidden = GetChromeHidden();
 
-  if (!chrome)
-    chrome = {};
-
-  function apiExists(path) {
-    var resolved = chrome;
-    path.split(".").forEach(function(next) {
-      if (resolved)
-        resolved = resolved[next];
-    });
-    return !!resolved;
-  }
+  // The object to generate the bindings for "internal" APIs in, so that
+  // extensions can't directly call them (without access to chromeHidden),
+  // but are still needed for internal mechanisms of extensions (e.g. events).
+  //
+  // This is distinct to the "*Private" APIs which are controlled via
+  // having strict permissions and aren't generated *anywhere* unless needed.
+  var internalAPIs = {};
+  chromeHidden.internalAPIs = internalAPIs;
 
   function forEach(dict, f) {
     for (key in dict) {
       if (dict.hasOwnProperty(key))
         f(key, dict[key]);
     }
   }
 
   // Validate arguments.
   chromeHidden.validationTypes = [];
@@ skipping 339 matching lines @@
     //   and validating either here, in a unit_test or both.
     // TODO(rafaelw): Handle synchronous functions.
     // TODO(rafaelw): Consider providing some convenient override points
     //   for api functions that wish to insert themselves into the call.
     var platform = getPlatform();
 
     apiDefinitions.forEach(function(apiDef) {
       if (!isSchemaNodeSupported(apiDef, platform, manifestVersion))
         return;
 
-      var module = chrome;
+      // See comment on internalAPIs at the top.
+      var module = apiDef.internal ? internalAPIs : chrome;
+
       var namespaces = apiDef.namespace.split('.');
       for (var index = 0, name; name = namespaces[index]; index++) {
         module[name] = module[name] || {};
         module = module[name];
       }
 
       // Add types to global validationTypes
       if (apiDef.types) {
         apiDef.types.forEach(function(t) {
           if (!isSchemaNodeSupported(t, platform, manifestVersion))
@@ skipping 168 matching lines @@
         apiFunctions: apiFunctions,
         sendRequest: sendRequest,
         setIcon: setIcon,
         apiDefinitions: apiDefinitions,
       }, extensionId);
     });
 
     // TOOD(mihaip): remove this alias once the webstore stops calling
     // beginInstallWithManifest2.
     // See http://crbug.com/100242
-    if (apiExists("webstorePrivate")) {
+    if (chrome.webstorePrivate) {
       chrome.webstorePrivate.beginInstallWithManifest2 =
           chrome.webstorePrivate.beginInstallWithManifest3;
     }
 
-    if (apiExists("test"))
+    if (chrome.test)
       chrome.test.getApiDefinitions = GetExtensionAPIDefinition;
   });
 })();