Issue 9309114: Allow "internal" APIs to be specified in extension API schemas.

Issue 9309114: Allow "internal" APIs to be specified in extension API schemas. (Closed)

Created:
8 years, 10 months ago by not at google - send to devlin

Modified:
8 years, 10 months ago

Reviewers:
Aaron Boodman, battre

CC:
chromium-reviews, darin-cc_chromium.org, mihaip+watch_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Allow "internal" APIs to be specified in extension API schemas, and specify the Declarative API as internal. BUG= TEST=browser_tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=121757

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Total comments: 1

Patch Set 5 : rebase #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+69 lines, -54 lines)			Patch
M	chrome/common/extensions/api/experimental.declarative.json	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/extensions/docs/build/directory.py	View	1	3 chunks	+12 lines, -5 lines	0 comments	Download
M	chrome/common/extensions/docs/examples/api/browsingData/basic.zip	View	1 2 3	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	chrome/common/extensions/docs/js/api_page_generator.js	View	1 2 3	5 chunks	+12 lines, -15 lines	0 comments	Download
M	chrome/common/extensions/docs/samples.json	View	1 2 3	2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/common/extensions/docs/static/samples.html	View	1	1 chunk	+3 lines, -4 lines	0 comments	Download
M	chrome/common/extensions/docs/template/api_template.html	View	1 2 3	4 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/renderer/resources/extensions/event.js	View	1 2 3	1 chunk	+21 lines, -9 lines	0 comments	Download
M	chrome/renderer/resources/extensions/schema_generated_bindings.js	View	1 2 3	3 chunks	+13 lines, -14 lines	0 comments	Download
M	chrome/test/data/extensions/api_test/declarative/api/manifest.json	View	1 2 3	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

not at google - send to devlin

https://chromiumcodereview.appspot.com/9309114/diff/5001/chrome/common/extensions/docs/samples.json File chrome/common/extensions/docs/samples.json (right): https://chromiumcodereview.appspot.com/9309114/diff/5001/chrome/common/extensions/docs/samples.json#newcode71 chrome/common/extensions/docs/samples.json:71: "chrome.experimental.extension.onInstalled": "experimental.extension.html#event-onInstalled", These changes just came from re-running the ...

8 years, 10 months ago (2012-02-13 04:47:09 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalman@chromium.org/9309114/5001

8 years, 10 months ago (2012-02-13 22:51:24 UTC) #4

commit-bot: I haz the power

8 years, 10 months ago (2012-02-13 22:51:29 UTC) #5

Presubmit check for 9309114-5001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Messages **
If this change has an associated bug, add BUG=[bug number].

** Presubmit Warnings **
This change modifies the extension docs but the generated docs have not been
updated properly. See chrome/common/extensions/docs/README.txt for more info.
(Report problems to tessamac@chromium.org.)
 - Changes to chrome/common/extensions/docs/static/samples.html not reflected in
generated doc.
First build DumpRenderTree, then update the docs by running:
  chrome/common/extensions/docs/build/build.py

Expand Messages | Collapse Messages