Refactored MouseWatcher to allow regions other than Views to

Refactored MouseWatcher to allow regions other than Views to
be monitored.

BUG=None
TEST=None

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=120583

[sky, 2012-02-06 16:03:34]

https://chromiumcodereview.appspot.com/9309110/diff/2001/chrome/browser/ui/vi...
File chrome/browser/ui/views/download/download_shelf_view.h (right):

https://chromiumcodereview.appspot.com/9309110/diff/2001/chrome/browser/ui/vi...
chrome/browser/ui/views/download/download_shelf_view.h:79: // Implementation of
MouseWatcherDelegate OVERRIDE.
MouseWatcherListener

https://chromiumcodereview.appspot.com/9309110/diff/2001/ui/views/mouse_watch...
File ui/views/mouse_watcher.cc (right):

https://chromiumcodereview.appspot.com/9309110/diff/2001/ui/views/mouse_watch...
ui/views/mouse_watcher.cc:119: void HandleGlobalMouseMoveEvent(bool
check_window) {
Change this to take MouseWatcherHost::MouseEventType

https://chromiumcodereview.appspot.com/9309110/diff/2001/ui/views/mouse_watch...
File ui/views/mouse_watcher.h (right):

https://chromiumcodereview.appspot.com/9309110/diff/2001/ui/views/mouse_watch...
ui/views/mouse_watcher.h:44: const gfx::Point& screen_point, MouseEventType
type) = 0;
nit: when you wrap, each param should be on its own line.

https://chromiumcodereview.appspot.com/9309110/diff/2001/ui/views/mouse_watch...
ui/views/mouse_watcher.h:46: 
nit: remove newline, and destructor before other methods.

https://chromiumcodereview.appspot.com/9309110/diff/2001/ui/views/mouse_watch...
File ui/views/mouse_watcher_view_host.cc (right):

https://chromiumcodereview.appspot.com/9309110/diff/2001/ui/views/mouse_watch...
ui/views/mouse_watcher_view_host.cc:23: const gfx::Point& screen_point,
MouseEventType type) {
nit: each param on its own line.

https://chromiumcodereview.appspot.com/9309110/diff/2001/ui/views/mouse_watch...
File ui/views/mouse_watcher_view_host.h (right):

https://chromiumcodereview.appspot.com/9309110/diff/2001/ui/views/mouse_watch...
ui/views/mouse_watcher_view_host.h:26: virtual bool Contains(const gfx::Point&
screen_point, MouseEventType type);
OVERRIDE

[DaveMoore, 2012-02-06 17:10:16]

http://codereview.chromium.org/9309110/diff/2001/chrome/browser/ui/views/down...
File chrome/browser/ui/views/download/download_shelf_view.h (right):

http://codereview.chromium.org/9309110/diff/2001/chrome/browser/ui/views/down...
chrome/browser/ui/views/download/download_shelf_view.h:79: // Implementation of
MouseWatcherDelegate OVERRIDE.
On 2012/02/06 16:03:34, sky wrote:
> MouseWatcherListener

Done.

http://codereview.chromium.org/9309110/diff/2001/ui/views/mouse_watcher.h
File ui/views/mouse_watcher.h (right):

http://codereview.chromium.org/9309110/diff/2001/ui/views/mouse_watcher.h#new...
ui/views/mouse_watcher.h:44: const gfx::Point& screen_point, MouseEventType
type) = 0;
On 2012/02/06 16:03:34, sky wrote:
> nit: when you wrap, each param should be on its own line.

Done.

http://codereview.chromium.org/9309110/diff/2001/ui/views/mouse_watcher.h#new...
ui/views/mouse_watcher.h:46: 
On 2012/02/06 16:03:34, sky wrote:
> nit: remove newline, and destructor before other methods.

Done.

http://codereview.chromium.org/9309110/diff/2001/ui/views/mouse_watcher_view_...
File ui/views/mouse_watcher_view_host.cc (right):

http://codereview.chromium.org/9309110/diff/2001/ui/views/mouse_watcher_view_...
ui/views/mouse_watcher_view_host.cc:23: const gfx::Point& screen_point,
MouseEventType type) {
On 2012/02/06 16:03:34, sky wrote:
> nit: each param on its own line.

Done.

http://codereview.chromium.org/9309110/diff/2001/ui/views/mouse_watcher_view_...
File ui/views/mouse_watcher_view_host.h (right):

http://codereview.chromium.org/9309110/diff/2001/ui/views/mouse_watcher_view_...
ui/views/mouse_watcher_view_host.h:26: virtual bool Contains(const gfx::Point&
screen_point, MouseEventType type);
On 2012/02/06 16:03:34, sky wrote:
> OVERRIDE

Done.

[sky, 2012-02-06 17:49:32]

LGTM