Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 9309090: Fix ref leak in WebSocketServerSocketImpl introduced in r115422. (Closed)

Created:
8 years, 10 months ago by Reid Kleckner
Modified:
8 years, 10 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, Timur Iskhodzhanov, Alexander Potapenko, pam+watch_chromium.org, darin-cc_chromium.org, stuartmorgan+watch_chromium.org
Visibility:
Public.

Description

Fix ref leak in WebSocketServerSocketImpl introduced in r115422. Also remove the heapcheck and memcheck suppressions. Added cbentzel and timurrrr for OWNERS approval. R=jhawkins@chromium.org,cbentzel@chromium.org,timurrrr@chromium.org BUG=108399 TEST=ran WebSocketServerSocketTest.* under drmemory Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=120775

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -18 lines) Patch
M net/socket/web_socket_server_socket.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/heapcheck/suppressions.txt View 1 chunk +0 lines, -8 lines 0 comments Download
M tools/valgrind/memcheck/suppressions.txt View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Reid Kleckner
8 years, 10 months ago (2012-02-03 20:11:37 UTC) #1
James Hawkins
lgtm
8 years, 10 months ago (2012-02-03 20:36:01 UTC) #2
cbentzel
LGTM
8 years, 10 months ago (2012-02-06 15:39:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rnk@chromium.org/9309090/1
8 years, 10 months ago (2012-02-06 20:42:46 UTC) #4
commit-bot: I haz the power
Try job failure for 9309090-1 (retry) (retry) (previous was lost) on mac_rel for steps "browser_tests, ...
8 years, 10 months ago (2012-02-07 01:27:04 UTC) #5
Reid Kleckner (google)
8 years, 10 months ago (2012-02-07 13:32:21 UTC) #6
I'm assuming this is the mac memcpy issue mentioned on Chromium-dev and
that the try bots need a clobber.  I don't know how to accomplish while
using the CQ.

Reid

On Mon, Feb 6, 2012 at 8:27 PM, <commit-bot@chromium.org> wrote:

> Try job failure for 9309090-1 (retry) (retry) (previous was lost) on
> mac_rel for
> steps "browser_tests, ui_tests".
> It's a second try, previously, step "browser_tests" failed.
> http://build.chromium.org/p/**tryserver.chromium/**
>
buildstatus?builder=mac_rel&**number=14442<http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=14442>
>
>
>
http://codereview.chromium.**org/9309090/<http://codereview.chromium.org/9309...
>

Powered by Google App Engine
This is Rietveld 408576698