Issue 9309077: MIPS: Don't allow large immediates for certain instructions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9309077: MIPS: Don't allow large immediates for certain instructions. (Closed)

Created:
8 years, 10 months ago by kalmard

Modified:
8 years, 10 months ago

Reviewers:
kisg, Paul Lind, danno

CC:
v8-dev

Visibility:
Public.

More Reviews

Description

MIPS: Don't allow large immediates for certain instructions. Some instructions can use >16 bit immediates if they represent a <=16 bit signed value. However some logical instructions (andi, xori, ori, lui) should always treat the immediate value as unsigned. This patch adds an ASSERT to these places and a minor change to MacroAssembler::li to satisfy this. BUG= TEST= Committed: https://code.google.com/p/v8/source/detail?r=10644

Patch Set 1 #

Patch Set 2 : rebased on r10618. #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -4 lines)			Patch
	M	src/mips/assembler-mips.cc	View		4 chunks	+4 lines, -0 lines	0 comments	Download
	M	src/mips/macro-assembler-mips.cc	View		1 chunk	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages