Swizzle Uniform Locations

Swizzle Uniform Locations

TEST=unit tests and ran OpenGL ES 2.0 conformance tests
BUG=106062
R=apatrick@chromium.org


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=120743

[greggman, 2012-02-02 01:49:43]

Hey Al, please review.

[apatrick_chromium, 2012-02-06 21:04:44]

https://chromiumcodereview.appspot.com/9309047/diff/3001/gpu/command_buffer/s...
File gpu/command_buffer/service/program_manager.cc (right):

https://chromiumcodereview.appspot.com/9309047/diff/3001/gpu/command_buffer/s...
gpu/command_buffer/service/program_manager.cc:636: GLint as_int;
Is there any need to do this on an unsigned int? It looks like the right shift
is in no danger of sign extending since the value to be shifted always has zero
in the MSB.

https://chromiumcodereview.appspot.com/9309047/diff/3001/gpu/command_buffer/s...
gpu/command_buffer/service/program_manager.cc:650: (unswizzled_location +
uniform_swizzle_);
Why add a random number?

[greggman, 2012-02-06 21:30:01]

https://chromiumcodereview.appspot.com/9309047/diff/3001/gpu/command_buffer/s...
File gpu/command_buffer/service/program_manager.cc (right):

https://chromiumcodereview.appspot.com/9309047/diff/3001/gpu/command_buffer/s...
gpu/command_buffer/service/program_manager.cc:636: GLint as_int;
On 2012/02/06 21:04:44, apatrick_chromium wrote:
> Is there any need to do this on an unsigned int? It looks like the right shift
> is in no danger of sign extending since the value to be shifted always has
zero
> in the MSB.

Done.

https://chromiumcodereview.appspot.com/9309047/diff/3001/gpu/command_buffer/s...
gpu/command_buffer/service/program_manager.cc:650: (unswizzled_location +
uniform_swizzle_);
On 2012/02/06 21:04:44, apatrick_chromium wrote:
> Why add a random number?

The random number is added because NaCl devs were found assuming locations, not
just on arrays but assuming that all drivers/GPUs would return the same
location. The random number means every run gets different locations.

[apatrick_chromium, 2012-02-06 22:04:06]

lgtm

[commit-bot: I haz the power, 2012-02-06 22:18:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gman@chromium.org/9309047/9001

[commit-bot: I haz the power, 2012-02-07 00:13:40]

The commit queue went berserk retrying too often for a
seemingly flaky test. Builder is mac_rel, revision is 120629, job name
was 9309047-9001 (previous was lost) (previous was lost) (previous was lost)
(previous was lost).

[commit-bot: I haz the power, 2012-02-07 00:39:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gman@chromium.org/9309047/9001

[commit-bot: I haz the power, 2012-02-07 05:32:43]

The commit queue went berserk retrying too often for a
seemingly flaky test. Builder is mac_rel, revision is 120695, job name
was 9309047-9001 (retry) (previous was lost) (previous was lost) (previous was
lost).

[commit-bot: I haz the power, 2012-02-07 06:56:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gman@chromium.org/9309047/9001

[commit-bot: I haz the power, 2012-02-07 08:22:29]

Change committed as 120743