Issue 9309024: Quick-and-dirty hacks for getting policy working behind proxies.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9309024: Quick-and-dirty hacks for getting policy working behind proxies. (Closed)

Created:
8 years, 10 months ago by xiyuan

Modified:
8 years, 10 months ago

Reviewers:
pastarmovj, Sumit, zel, Mattias Nissler (ping if slow), kuan

CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Quick-and-dirty hacks for getting policy working behind proxies. This is check-in for mattias. Original review: http://codereview.chromium.org/9315011/ Note that this hard-wires policy OAuth fetching in login_utils.cc to the authentication profile. I'm not entirely sure this is a good idea, but required since the user profile isn't in a state to allow successful requests at this point (the use-shared-proxies flag is off). Other stuff in login_utils.cc might need the hack too (sync?). BUG=chromium-os:25703 TEST=Verify fix for chromium-os:25703 TBR=mnissler@chromium.org,zelidrag@chromium.org,sumit@chromium.org,pastarmovj@chromium.org,kuan@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=120013

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -7 lines)			Patch
	M	chrome/browser/chromeos/login/login_utils.cc	View		3 chunks	+11 lines, -5 lines	0 comments	Download
	M	chrome/browser/chromeos/proxy_config_service_impl.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download