Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(946)

Issue 9309019: Add argument use_poll=True to asyncore.loop() calls in perf_snapshot.py. (Closed)

Created:
8 years, 10 months ago by dennis_jeffrey
Modified:
8 years, 10 months ago
Reviewers:
Nirnimesh
CC:
chromium-reviews, dennis_jeffrey, John Grabowski, anantha, dyu1, Nirnimesh
Visibility:
Public.

Description

Add argument use_poll=True to asyncore.loop() calls in perf_snapshot.py. This change causes asyncore.loop() to internally use poll() instead of select(), which may prevent the "bad file descriptor" exception from being thrown on the Chrome Endure tests. Also enhanced an assertion error message in perf_endure.py to give more context if the assertion is violated. BUG=None TEST=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=119983

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M chrome/test/functional/perf_endure.py View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/test/pyautolib/perf_snapshot.py View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
dennis_jeffrey
Before having the Chrome Endure tests tolerate asyncore.loop() exceptions, I'd like to try this change ...
8 years, 10 months ago (2012-01-31 23:04:37 UTC) #1
Nirnimesh
8 years, 10 months ago (2012-01-31 23:09:19 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698