Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2244)

Unified Diff: chrome/browser/resources/uber/uber.js

Issue 9309018: [uber page] Fix url handling for uber-page sub-paths. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/uber/uber.js
===================================================================
--- chrome/browser/resources/uber/uber.js (revision 119926)
+++ chrome/browser/resources/uber/uber.js (working copy)
@@ -30,6 +30,7 @@
var params = resolvePageInfoFromPath(window.location.pathname);
if (params.path) {
Evan Stade 2012/01/31 22:58:49 can you move this block to after showPage instead?
csilv 2012/02/01 00:10:49 Done.
var iframe = $(params.id).querySelector('iframe');
+ iframe.src = iframe.dataset.url;
iframe.contentWindow.location.replace(iframe.src + params.path);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698