Issue 9309018: [uber page] Fix url handling for uber-page sub-paths.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9309018: [uber page] Fix url handling for uber-page sub-paths. (Closed)

Created:
8 years, 10 months ago by csilv

Modified:
8 years, 10 months ago

Reviewers:
Evan Stade

CC:
chromium-reviews, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

[uber page] Fix url handling for uber-page sub-paths. BUG=111900 TEST=Invoke 'Clear Browsing Data' from the wrench menu, should bring up the correct dialog. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=120006

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -11 lines)			Patch
	M	chrome/browser/resources/uber/uber.js	View	1	3 chunks	+9 lines, -11 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Evan Stade

https://chromiumcodereview.appspot.com/9309018/diff/1/chrome/browser/resources/uber/uber.js File chrome/browser/resources/uber/uber.js (right): https://chromiumcodereview.appspot.com/9309018/diff/1/chrome/browser/resources/uber/uber.js#newcode31 chrome/browser/resources/uber/uber.js:31: if (params.path) { can you move this block to ...

8 years, 10 months ago (2012-01-31 22:58:49 UTC) #2

csilv

8 years, 10 months ago (2012-02-01 00:10:49 UTC) #3

lgtm

Expand Messages | Collapse Messages