Issue 9309012: Put various nacl headers back under nacl/ where they have previously been

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9309012: Put various nacl headers back under nacl/ where they have previously been (Closed)

Created:
8 years, 10 months ago by elijahtaylor (use chromium)

Modified:
8 years, 10 months ago

Reviewers:
noelallen1

CC:
chromium-reviews, pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Put various nacl headers back under nacl/ where they have previously been BUG=none TEST=trybots,manual (build SDK, inspect headers) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=120036

Patch Set 1 #

Patch Set 2 : 80 cols #

Patch Set 3 : remove duplicate entry #

Total comments: 1

Patch Set 4 : feedback #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -10 lines)			Patch
	M	native_client_sdk/src/build_tools/buildbot_run.py	View	1 2 3	2 chunks	+11 lines, -10 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

noelallen1

One nit, otherwise LGTM https://chromiumcodereview.appspot.com/9309012/diff/3003/native_client_sdk/src/build_tools/buildbot_run.py File native_client_sdk/src/build_tools/buildbot_run.py (right): https://chromiumcodereview.appspot.com/9309012/diff/3003/native_client_sdk/src/build_tools/buildbot_run.py#newcode210 native_client_sdk/src/build_tools/buildbot_run.py:210: if not os.path.exists(os.path.dirname(dst)): Shouldn't need ...

8 years, 10 months ago (2012-01-31 23:57:14 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/elijahtaylor@google.com/9309012/4002

8 years, 10 months ago (2012-02-01 03:51:49 UTC) #3

Change committed as 120036

Expand Messages | Collapse Messages