Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 9307115: PPB_NetAddress_Private: add getter methods for sockaddr. (Closed)

Created:
8 years, 10 months ago by yzshen1
Modified:
8 years, 10 months ago
Reviewers:
brettw
CC:
chromium-reviews, piman+watch_chromium.org, darin-cc_chromium.org, yzshen+watch_chromium.org, ihf+watch_chromium.org
Visibility:
Public.

Description

PPB_NetAddress_Private: add getter methods for sockaddr. This CL is mostly contributed by Vinay(vinaya@adobe.com): http://codereview.chromium.org/9235035 Comparing with 9235035, this change: - fixes the NaCl Proxy. - adds untrusted tests. - does other small fixes. BUG=None TEST=test_net_address_private and test_net_address_private_untrusted Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=121106

Patch Set 1 #

Patch Set 2 : The change to 9235035 starts from this patch set. #

Patch Set 3 : . #

Patch Set 4 : sync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+619 lines, -34 lines) Patch
M AUTHORS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/ui/ppapi_uitest.cc View 1 2 3 1 chunk +9 lines, -0 lines 0 comments Download
M ppapi/api/private/ppb_net_address_private.idl View 1 2 chunks +26 lines, -1 line 0 comments Download
M ppapi/c/private/ppb_net_address_private.h View 1 4 chunks +37 lines, -4 lines 0 comments Download
M ppapi/cpp/private/net_address_private.h View 1 2 chunks +5 lines, -1 line 0 comments Download
M ppapi/cpp/private/net_address_private.cc View 1 2 chunks +30 lines, -3 lines 0 comments Download
M ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_net_address_private_rpc_server.cc View 1 1 chunk +74 lines, -0 lines 0 comments Download
M ppapi/native_client/src/shared/ppapi_proxy/plugin_ppb.cc View 1 1 chunk +4 lines, -2 lines 0 comments Download
M ppapi/native_client/src/shared/ppapi_proxy/plugin_ppb_net_address_private.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M ppapi/native_client/src/shared/ppapi_proxy/plugin_ppb_net_address_private.cc View 1 1 chunk +84 lines, -2 lines 0 comments Download
M ppapi/native_client/src/shared/ppapi_proxy/ppb_net_address_private.srpc View 1 1 chunk +19 lines, -0 lines 0 comments Download
M ppapi/native_client/src/shared/ppapi_proxy/ppb_rpc_client.cc View 1 1 chunk +53 lines, -0 lines 0 comments Download
M ppapi/native_client/src/shared/ppapi_proxy/ppb_rpc_server.cc View 1 2 chunks +46 lines, -0 lines 0 comments Download
M ppapi/native_client/src/shared/ppapi_proxy/trusted/srpcgen/ppb_rpc.h View 1 1 chunk +16 lines, -0 lines 0 comments Download
M ppapi/native_client/src/shared/ppapi_proxy/untrusted/srpcgen/ppb_rpc.h View 1 1 chunk +13 lines, -0 lines 0 comments Download
M ppapi/shared_impl/private/net_address_private_impl.cc View 1 9 chunks +62 lines, -17 lines 0 comments Download
M ppapi/tests/test_net_address_private.h View 1 2 chunks +4 lines, -2 lines 0 comments Download
M ppapi/tests/test_net_address_private.cc View 1 2 3 chunks +77 lines, -1 line 0 comments Download
M ppapi/tests/test_net_address_private_untrusted.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M ppapi/tests/test_net_address_private_untrusted.cc View 1 2 chunks +52 lines, -0 lines 0 comments Download
M ppapi/thunk/interfaces_ppb_private.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
yzshen1
Hi, Brett. Would you please take a look? Please diff against the patch set 1 ...
8 years, 10 months ago (2012-02-05 22:56:26 UTC) #1
brettw
lgtm
8 years, 10 months ago (2012-02-06 20:17:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yzshen@chromium.org/9307115/2009
8 years, 10 months ago (2012-02-06 20:21:16 UTC) #3
commit-bot: I haz the power
8 years, 10 months ago (2012-02-06 20:21:27 UTC) #4
Presubmit check for 9307115-2009 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Warnings **
Found lines longer than 80 characters (first 5 shown).
  ppapi/native_client/src/shared/ppapi_proxy/ppb_rpc_server.cc, line 3019, 89
chars \
  ppapi/native_client/src/shared/ppapi_proxy/ppb_rpc_server.cc, line 3020, 85
chars \
  ppapi/native_client/src/shared/ppapi_proxy/ppb_rpc_server.cc, line 3021, 92
chars

Presubmit checks took 3.8s to calculate.

Powered by Google App Engine
This is Rietveld 408576698