Coverity: Initialize member variables.

ppapi/native_client/src/shared/ppapi_proxy/ppp_instance_combined.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ppapi/native_client/src/shared/ppapi_proxy/ppp_instance_combined.h"
 
 #include <stdlib.h>
+#include <string.h>
 
 namespace ppapi_proxy {
 
 PPP_Instance_Combined::PPP_Instance_Combined()
     : initialized_(false),
       did_change_view_1_0_(NULL) {
+  memset(&instance_1_1_, 0, sizeof(instance_1_1_));

[dmichael (off chromium), 2012/02/06 18:38:07]

doesn't it suffice to just put instance_1_1_() in the initializer list?

[James Hawkins, 2012/02/07 21:09:21]

The default constructor doesn't initialize the POD types (in this case, the
function pointers).

[dmichael (off chromium), 2012/02/07 21:30:19]

instance_1_1_ is a POD struct. Adding instance_1_1_() to the initializer list
"value-initializes" instance_1_1_, which means the pointers are all set to NULL.
See, e.g.:
http://stackoverflow.com/questions/3803153/what-are-primitive-types-default-i...

That said, not everyone knows that, so memset may be clearer. I'm fine either
way.

 }
 
 void PPP_Instance_Combined::Init1_0(const PPP_Instance_1_0* instance_if) {
   initialized_ = true;
   did_change_view_1_0_ = instance_if->DidChangeView;
   instance_1_1_.DidCreate = instance_if->DidCreate;
   instance_1_1_.DidDestroy = instance_if->DidDestroy;
   instance_1_1_.DidChangeView = NULL;
   instance_1_1_.DidChangeFocus = instance_if->DidChangeFocus;
   instance_1_1_.HandleDocumentLoad = instance_if->HandleDocumentLoad;
@@ skipping 30 matching lines @@
   instance_1_1_.DidChangeFocus(instance, has_focus);
 }
 
 PP_Bool PPP_Instance_Combined::HandleDocumentLoad(PP_Instance instance,
                                                   PP_Resource url_loader) {
   return instance_1_1_.HandleDocumentLoad(instance, url_loader);
 }
 
 }  // namespace ppapi_proxy