Coverity: Initialize member variables.

base/debug/trace_event_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/debug/trace_event_impl.h"
 
 #include <algorithm>
 
 #include "base/bind.h"
 #include "base/debug/trace_event.h"
@@ skipping 127 matching lines @@
 
 }  // namespace
 
 TraceEvent::TraceEvent()
     : id_(0u),
       category_enabled_(NULL),
       name_(NULL),
       thread_id_(0),
       phase_(TRACE_EVENT_PHASE_BEGIN),
       flags_(0) {
-  arg_names_[0] = NULL;
-  arg_names_[1] = NULL;
+  memset(arg_names_, 0, sizeof(arg_names_));

[groby-ooo-7-16, 2012/02/06 18:39:48]

Technically, the old way was OK - those are both strings. I wouldn't usually
mind the memset, but TraceEvent is performance critical IIRC :)

[James Hawkins, 2012/02/07 21:09:21]

You're right, and Coverity wasn't even complaining about |arg_names_| anyway.

+  memset(arg_values_, 0, sizeof(arg_values_));
 }
 
 TraceEvent::TraceEvent(int thread_id,
                        TimeTicks timestamp,
                        char phase,
                        const unsigned char* category_enabled,
                        const char* name,
                        unsigned long long id,
                        int num_args,
                        const char** arg_names,
@@ skipping 554 matching lines @@
   // Create a FNV hash from the process ID for XORing.
   // See http://isthe.com/chongo/tech/comp/fnv/ for algorithm details.
   unsigned long long offset_basis = 14695981039346656037ull;
   unsigned long long fnv_prime = 1099511628211ull;
   unsigned long long pid = static_cast<unsigned long long>(process_id_);
   process_id_hash_ = (offset_basis ^ pid) * fnv_prime;
 }
 
 }  // namespace debug
 }  // namespace base