Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(476)

Issue 9307087: Remove code for Mac and Linux virtual print drivers. (Closed)

Created:
8 years, 10 months ago by Albert Bodenhamer
Modified:
8 years, 10 months ago
Reviewers:
Nico, Scott Byer
CC:
chromium-reviews
Visibility:
Public.

Description

There are significant structural and functional issues with this code. I was going to remove just the Mac code, but doing so revealed issues with the Linux code as well. BUG=111652 TEST= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=120993

Patch Set 1 #

Patch Set 2 : Nuke linux too #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -804 lines) Patch
M build/all.gyp View 1 1 chunk +1 line, -2 lines 0 comments Download
M cloud_print/virtual_driver/posix/backend.gyp View 1 1 chunk +0 lines, -76 lines 1 comment Download
D cloud_print/virtual_driver/posix/install_cloud_print_driver_mac.mm View 1 1 chunk +0 lines, -20 lines 0 comments Download
D cloud_print/virtual_driver/posix/installer_util_mac.h View 1 chunk +0 lines, -16 lines 0 comments Download
D cloud_print/virtual_driver/posix/installer_util_mac.mm View 1 chunk +0 lines, -69 lines 0 comments Download
D cloud_print/virtual_driver/posix/linux_packaging/build.sh View 1 1 chunk +0 lines, -60 lines 0 comments Download
D cloud_print/virtual_driver/posix/mac_packaging/build_mac.sh View 1 chunk +0 lines, -47 lines 0 comments Download
D cloud_print/virtual_driver/posix/printer_driver_util_linux.cc View 1 1 chunk +0 lines, -51 lines 0 comments Download
D cloud_print/virtual_driver/posix/printer_driver_util_mac.mm View 1 chunk +0 lines, -128 lines 0 comments Download
D cloud_print/virtual_driver/posix/printer_driver_util_posix.h View 1 1 chunk +0 lines, -24 lines 0 comments Download
D cloud_print/virtual_driver/posix/printer_driver_util_posix.cc View 1 1 chunk +0 lines, -99 lines 0 comments Download
D cloud_print/virtual_driver/posix/uninstall_cloud_print_driver_mac.mm View 1 chunk +0 lines, -20 lines 0 comments Download
D cloud_print/virtual_driver/posix/virtual_driver_posix.cc View 1 1 chunk +0 lines, -102 lines 0 comments Download
D cloud_print/virtual_driver/posix/virtual_driver_posix_tests.cc View 1 1 chunk +0 lines, -75 lines 0 comments Download
D cloud_print/virtual_driver/virtual_driver_posix.gyp View 1 1 chunk +0 lines, -15 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Albert Bodenhamer
8 years, 10 months ago (2012-02-03 22:33:10 UTC) #1
Scott Byer
LGTM. Nuke it from orbit, it's the only way to be sure. On 2012/02/03 22:33:10, ...
8 years, 10 months ago (2012-02-03 22:36:59 UTC) #2
Nico
lgtm awesome, thanks! http://codereview.chromium.org/9307087/diff/4001/cloud_print/virtual_driver/posix/backend.gyp File cloud_print/virtual_driver/posix/backend.gyp (left): http://codereview.chromium.org/9307087/diff/4001/cloud_print/virtual_driver/posix/backend.gyp#oldcode6 cloud_print/virtual_driver/posix/backend.gyp:6: 'target_defaults': { This file shows up ...
8 years, 10 months ago (2012-02-03 23:58:39 UTC) #3
Albert Bodenhamer
8 years, 10 months ago (2012-02-06 17:28:09 UTC) #4
On 2012/02/03 23:58:39, Nico wrote:
> lgtm
> 
> awesome, thanks!
> 
>
http://codereview.chromium.org/9307087/diff/4001/cloud_print/virtual_driver/p...
> File cloud_print/virtual_driver/posix/backend.gyp (left):
> 
>
http://codereview.chromium.org/9307087/diff/4001/cloud_print/virtual_driver/p...
> cloud_print/virtual_driver/posix/backend.gyp:6: 'target_defaults': {
> This file shows up as 'M' instead of 'D'?
Odd.  Probably since I initially started with an edit of the file and then
deleted after.  Applying the patch seems to delete properly.

I'll go ahead and submit.  If anything weird results I'll clean it up in a
second CL.

Powered by Google App Engine
This is Rietveld 408576698