chrome/browser/ui/cocoa/web_intent_bubble_controller.mm - Issue 9307086: [Web Intents, Mac] Allow re-open after cancellation/close of picker bubble

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/web_intent_bubble_controller.mm

Issue 9307086: [Web Intents, Mac] Allow re-open after cancellation/close of picker bubble (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Added missing message loop Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/cocoa/web_intent_bubble_controller.mm

diff --git a/chrome/browser/ui/cocoa/web_intent_bubble_controller.mm b/chrome/browser/ui/cocoa/web_intent_bubble_controller.mm

index 86df521f5fdfff9c5c302ba7d767c45f2239087d..aec0f26ae39de291a665a7037a0485c070ef6cda 100644

--- a/chrome/browser/ui/cocoa/web_intent_bubble_controller.mm

+++ b/chrome/browser/ui/cocoa/web_intent_bubble_controller.mm

@@ -124,11 +124,8 @@ const CGFloat kTextWidth = kWindowWidth - (kImageSize + kImageSpacing +

// A picker button has been pressed - invoke corresponding service.

- (IBAction)invokeService:(id)sender {

- if (picker_) {

- WebIntentPickerCocoa* temp = picker_;

- picker_ = NULL; // Abandon picker, we are done with it.

- temp->OnServiceChosen([sender tag]);

- }

+ if (picker_)

+ picker_->OnServiceChosen([sender tag]);

}

// Sets proprties on the given |field| to act as the title or description labels

« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/web_intent_bubble_controller_unittest.mm » ('j') | no next file with comments »