Split TabContentsViewMac.

content/public/browser/web_contents_view_mac_delegate.h

Index: content/public/browser/web_contents_view_mac_delegate.h
diff --git a/content/public/browser/web_contents_view_mac_delegate.h b/content/public/browser/web_contents_view_mac_delegate.h
new file mode 100644
index 0000000000000000000000000000000000000000..44867eacc78c3f553e5cdcd67d439e4021e4ae6b
--- /dev/null
+++ b/content/public/browser/web_contents_view_mac_delegate.h
@@ -0,0 +1,47 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_VIEW_MAC_DELEGATE_H_
+#define CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_VIEW_MAC_DELEGATE_H_
+#pragma once
+
+#import <Cocoa/Cocoa.h>
+
+#include "content/common/content_export.h"
+
+struct ContextMenuParams;
+class RenderWidgetHost;
+@protocol RenderWidgetHostViewMacDelegate;
+
+namespace content {
+
+class WebDragDestDelegate;
+
+// This interface allows a client to extend the functionality of
+// WebContentsViewMac.
+

[jochen (gone - plz use gerrit), 2012/02/03 00:13:33]

nit. no empty line?

[Avi (use Gerrit), 2012/02/03 01:18:53]

Done.

+class CONTENT_EXPORT WebContentsViewMacDelegate {
+ public:
+  virtual ~WebContentsViewMacDelegate() {}
+
+  // Returns a newly-created delegate for the RenderWidgetHostViewMac, to handle
+  // events on the responder chain.
+  virtual NSObject<RenderWidgetHostViewMacDelegate>*
+      CreateRenderWidgetHostViewDelegate(
+          RenderWidgetHost* render_widget_host) = 0;
+
+  // Returns a delegate to process drags not handled by content.
+  virtual WebDragDestDelegate* DragDelegate() = 0;
+
+  // Shows a context menu.
+  virtual void ShowContextMenu(const ContextMenuParams& params) = 0;

[jam, 2012/02/03 00:29:15]

i think this isn't needed because WebContentsDelegate::HandleContextMenu is also
called and that's how the embedder hooks in (I would actually prefer if ended up
removing it from WebContentsView altogether, if chrome is only using it from the
delegate interface)

[Avi (use Gerrit), 2012/02/03 01:18:53]

Look at the implementation of this. It's the TCVs who call
WebContentsDelegate::HandleContextMenu.

To be more precise, the flow is:

RenderViewHost::OnMsgContextMenu handles the IPC from the renderer. It says:

  RenderViewHostDelegate::View* view = delegate_->GetViewDelegate();
  [...]
  view->ShowContextMenu(validated_params);

The TabContentsViews _are_ the RVHD::Views.

If all the TCV::ShowContextMenu implementations are going to do is immediately
call into WebContentsDelegate::HandleContextMenu, sure. But we can't put that
into the RenderViewHost code, as that's a layering violation. And we have no
common base class for the TCVs.

I don't see how to do it otherwise.

[jam, 2012/02/03 07:59:17]

RenderViewHost will call TabContentsViewMac::ShowContextMenu. That
implementation calls TabContentsDelegate::ShowContextMenu. Am I missing
something/

+
+  // Notifications that the native view was created/destroyed.
+  virtual void NativeViewCreated(NSView* view) = 0;
+  virtual void NativeViewDestroyed(NSView* view) = 0;
+};
+
+}  // namespace content
+
+#endif  // CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_VIEW_MAC_DELEGATE_H_