Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(446)

Side by Side Diff: chrome/browser/tab_contents/chrome_web_contents_view_mac_delegate.mm

Issue 9307063: Split TabContentsViewMac. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: deps fix Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
(Empty)
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #import "chrome/browser/tab_contents/chrome_web_contents_view_mac_delegate.h"
6
7 #import "chrome/browser/renderer_host/chrome_render_widget_host_view_mac_delegat e.h"
8 #include "chrome/browser/tab_contents/render_view_context_menu_mac.h"
9 #include "chrome/browser/tab_contents/web_drag_bookmark_handler_mac.h"
10 #import "chrome/browser/ui/cocoa/view_id_util.h"
11 #include "content/browser/renderer_host/render_widget_host_view.h"
12 #include "content/public/browser/web_contents.h"
13
14 namespace chrome_web_contents_view_mac_delegate {
15 content::WebContentsViewMacDelegate* CreateWebContentsViewMacDelegate(
16 content::WebContents* web_contents) {
17 return new ChromeWebContentsViewMacDelegate(web_contents);
18 }
19 }
jochen (gone - plz use gerrit) 2012/02/03 00:13:33 } // namespace $fancy
Avi (use Gerrit) 2012/02/03 01:18:53 For a namespace that tightly wrapped around a shim
20
21 ChromeWebContentsViewMacDelegate::ChromeWebContentsViewMacDelegate(
22 content::WebContents* web_contents)
23 : bookmark_handler_(new WebDragBookmarkHandlerMac),
24 web_contents_(web_contents) {
25 }
26
27 ChromeWebContentsViewMacDelegate::~ChromeWebContentsViewMacDelegate() {
28 }
29
30 NSObject<RenderWidgetHostViewMacDelegate>*
31 ChromeWebContentsViewMacDelegate::CreateRenderWidgetHostViewDelegate(
32 RenderWidgetHost* render_widget_host) {
33 return [[ChromeRenderWidgetHostViewMacDelegate alloc]
34 initWithRenderWidgetHost:render_widget_host];
35 }
36
jochen (gone - plz use gerrit) 2012/02/03 00:13:33 only one empty line
Avi (use Gerrit) 2012/02/03 01:18:53 Done.
37
38 content::WebDragDestDelegate* ChromeWebContentsViewMacDelegate::DragDelegate() {
39 return static_cast<content::WebDragDestDelegate*>(bookmark_handler_.get());
40 }
41
42 void ChromeWebContentsViewMacDelegate::ShowContextMenu(
43 const ContextMenuParams& params) {
44 // The renderer may send the "show context menu" message multiple times, one
45 // for each right click mouse event it receives. Normally, this doesn't happen
46 // because mouse events are not forwarded once the context menu is showing.
47 // However, there's a race - the context menu may not yet be showing when
48 // the second mouse event arrives. In this case, |ShowContextMenu()| will
49 // get called multiple times - if so, don't create another context menu.
50 // TODO(asvitkine): Fix the renderer so that it doesn't do this.
51 RenderWidgetHostView* widget_view = web_contents_->GetRenderWidgetHostView();
52 if (widget_view && widget_view->showing_context_menu())
53 return;
54
55 context_menu_.reset(
56 new RenderViewContextMenuMac(web_contents_,
57 params,
58 web_contents_->GetContentNativeView()));
59 context_menu_->Init();
60 }
61
62 void ChromeWebContentsViewMacDelegate::NativeViewCreated(NSView* view) {
63 view_id_util::SetID(view, VIEW_ID_TAB_CONTAINER);
64 }
65
66 void ChromeWebContentsViewMacDelegate::NativeViewDestroyed(NSView* view) {
67 view_id_util::UnsetID(view);
68 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698