Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Side by Side Diff: src/x64/ic-x64.cc

Issue 9307056: Fix elements transition bug on x64 in generic KeyedStoreIC (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 747 matching lines...) Expand 10 before | Expand all | Expand 10 after
758 // If the value is a number, store it as a double in the FastDoubleElements 758 // If the value is a number, store it as a double in the FastDoubleElements
759 // array. 759 // array.
760 __ StoreNumberToDoubleElements(rax, rbx, rcx, xmm0, 760 __ StoreNumberToDoubleElements(rax, rbx, rcx, xmm0,
761 &transition_double_elements); 761 &transition_double_elements);
762 __ ret(0); 762 __ ret(0);
763 763
764 __ bind(&transition_smi_elements); 764 __ bind(&transition_smi_elements);
765 __ movq(rbx, FieldOperand(rdx, HeapObject::kMapOffset)); 765 __ movq(rbx, FieldOperand(rdx, HeapObject::kMapOffset));
766 766
767 // Transition the array appropriately depending on the value type. 767 // Transition the array appropriately depending on the value type.
768 __ movq(r9, FieldOperand(rax, HeapObject::kMapOffset));
768 __ CompareRoot(r9, Heap::kHeapNumberMapRootIndex); 769 __ CompareRoot(r9, Heap::kHeapNumberMapRootIndex);
769 __ j(not_equal, &non_double_value); 770 __ j(not_equal, &non_double_value);
770 771
771 // Value is a double. Transition FAST_SMI_ONLY_ELEMENTS -> 772 // Value is a double. Transition FAST_SMI_ONLY_ELEMENTS ->
772 // FAST_DOUBLE_ELEMENTS and complete the store. 773 // FAST_DOUBLE_ELEMENTS and complete the store.
773 __ LoadTransitionedArrayMapConditional(FAST_SMI_ONLY_ELEMENTS, 774 __ LoadTransitionedArrayMapConditional(FAST_SMI_ONLY_ELEMENTS,
774 FAST_DOUBLE_ELEMENTS, 775 FAST_DOUBLE_ELEMENTS,
775 rbx, 776 rbx,
776 rdi, 777 rdi,
777 &slow); 778 &slow);
(...skipping 995 matching lines...) Expand 10 before | Expand all | Expand 10 after
1773 Condition cc = *jmp_address == Assembler::kJncShortOpcode 1774 Condition cc = *jmp_address == Assembler::kJncShortOpcode
1774 ? not_zero 1775 ? not_zero
1775 : zero; 1776 : zero;
1776 *jmp_address = static_cast<byte>(Assembler::kJccShortPrefix | cc); 1777 *jmp_address = static_cast<byte>(Assembler::kJccShortPrefix | cc);
1777 } 1778 }
1778 1779
1779 1780
1780 } } // namespace v8::internal 1781 } } // namespace v8::internal
1781 1782
1782 #endif // V8_TARGET_ARCH_X64 1783 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698