Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 9307043: Revert 120111 - Defer render_widget draw until host window is available (Closed)

Created:
8 years, 10 months ago by scottmg
Modified:
8 years, 10 months ago
Reviewers:
jamesr
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Revert 120111 - Defer render_widget draw until host window is available In accelerated compositing mode we can't start rendering until the native window (HWND/gtk widget) are created on Windows and GTK without aura. For most render_widgets the code today is racy, but for window.open() and similar creation paths this is a race that we pretty much always lose. This defers the first DoDeferredUpdate on a render_widget until its host_window_ is available. Also defers querying for GL_CHROMIUM_supports_swapbuffers_callback extension until the first draw, since the context isn't ready until the host window is available. BUG=106815 TEST=start with --force-compositing-mode and --show-fps-counter, load up a page that uses window.open() to open a popup, and confirm that the popup is in compositing mode Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=119977 Review URL: http://codereview.chromium.org/9225050 TBR=jamesr@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=120130

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -33 lines) Patch
M content/renderer/render_view_impl.h View 1 chunk +0 lines, -7 lines 0 comments Download
M content/renderer/render_view_impl.cc View 2 chunks +5 lines, -16 lines 0 comments Download
M content/renderer/render_widget.cc View 4 chunks +4 lines, -10 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
scottmg
8 years, 10 months ago (2012-02-01 23:29:30 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698