Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 9307039: [uber page] Fix font-family for button and select elements on uber pages. (Closed)

Created:
8 years, 10 months ago by csilv
Modified:
8 years, 10 months ago
Reviewers:
James Hawkins, Dan Beam
CC:
chromium-reviews, arv (Not doing code reviews)
Visibility:
Public.

Description

[uber page] Fix font-family for button and select elements on uber pages. BUG=112360 TEST=Manual. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=120136

Patch Set 1 #

Patch Set 2 : select elements too. #

Total comments: 4

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -9 lines) Patch
M chrome/browser/resources/options2/options_page.css View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/shared/css/button.css View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/resources/shared/css/select.css View 1 2 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
csilv
+dbeam for review
8 years, 10 months ago (2012-02-01 21:53:46 UTC) #1
csilv
Hold off on your review, I need to also fix select controls.
8 years, 10 months ago (2012-02-01 21:56:08 UTC) #2
csilv
On 2012/02/01 21:56:08, csilv wrote: > Hold off on your review, I need to also ...
8 years, 10 months ago (2012-02-01 22:01:21 UTC) #3
Dan Beam
https://chromiumcodereview.appspot.com/9307039/diff/1003/chrome/browser/resources/options2/options_page.css File chrome/browser/resources/options2/options_page.css (right): https://chromiumcodereview.appspot.com/9307039/diff/1003/chrome/browser/resources/options2/options_page.css#newcode103 chrome/browser/resources/options2/options_page.css:103: /* TODO(csilv): Move some of this styling to a ...
8 years, 10 months ago (2012-02-01 23:07:29 UTC) #4
csilv
https://chromiumcodereview.appspot.com/9307039/diff/1003/chrome/browser/resources/options2/options_page.css File chrome/browser/resources/options2/options_page.css (right): https://chromiumcodereview.appspot.com/9307039/diff/1003/chrome/browser/resources/options2/options_page.css#newcode103 chrome/browser/resources/options2/options_page.css:103: /* TODO(csilv): Move some of this styling to a ...
8 years, 10 months ago (2012-02-01 23:18:29 UTC) #5
Dan Beam
lgtm w/nit https://chromiumcodereview.appspot.com/9307039/diff/1003/chrome/browser/resources/options2/options_page.css File chrome/browser/resources/options2/options_page.css (right): https://chromiumcodereview.appspot.com/9307039/diff/1003/chrome/browser/resources/options2/options_page.css#newcode103 chrome/browser/resources/options2/options_page.css:103: /* TODO(csilv): Move some of this styling ...
8 years, 10 months ago (2012-02-02 00:15:55 UTC) #6
csilv
+jhawkins for OWNERS. https://chromiumcodereview.appspot.com/9307039/diff/1003/chrome/browser/resources/options2/options_page.css File chrome/browser/resources/options2/options_page.css (right): https://chromiumcodereview.appspot.com/9307039/diff/1003/chrome/browser/resources/options2/options_page.css#newcode103 chrome/browser/resources/options2/options_page.css:103: /* TODO(csilv): Move some of this ...
8 years, 10 months ago (2012-02-02 00:57:49 UTC) #7
James Hawkins
8 years, 10 months ago (2012-02-02 01:00:40 UTC) #8
lgtm

Powered by Google App Engine
This is Rietveld 408576698