chrome/tools/check_grd_for_unused_strings.py - Issue 9307037: Reland http://codereview.chromium.org/9121050/ with fix for aura_win

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/tools/check_grd_for_unused_strings.py

Issue 9307037: Reland http://codereview.chromium.org/9121050/ with fix for aura_win (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Separate ash_strings into its own gyp to break circular dependencies Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/tools/check_grd_for_unused_strings.py

diff --git a/chrome/tools/check_grd_for_unused_strings.py b/chrome/tools/check_grd_for_unused_strings.py

index 1f51272af29dc246e3b640c7109bd717ac5fc37a..427c4bfdf494295ab132ca0562eefe7326de3cd6 100755

--- a/chrome/tools/check_grd_for_unused_strings.py

+++ b/chrome/tools/check_grd_for_unused_strings.py

@@ -126,11 +126,13 @@ def main():

# If no GRD files were given, default them:

if len(grd_files) == 0:

+ ash_base_dir = os.path.join(src_dir, 'ash')

chrome_dir = os.path.join(src_dir, 'chrome')

chrome_app_dir = os.path.join(chrome_dir, 'app')

chrome_app_res_dir = os.path.join(chrome_app_dir, 'resources')

ui_base_dir = os.path.join(src_dir, 'ui', 'base', 'strings')

grd_files = [

+ os.path.join(ash_base_dir, 'ash_strings.grd'),

os.path.join(chrome_app_dir, 'chromium_strings.grd'),

os.path.join(chrome_app_dir, 'generated_resources.grd'),

os.path.join(chrome_app_dir, 'google_chrome_strings.grd'),

« no previous file with comments | « chrome/tools/build/repack_locales.py ('k') | tools/gritsettings/resource_ids » ('j') | no next file with comments »