Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(732)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/chrome_resources.gyp

Issue 9307037: Reland http://codereview.chromium.org/9121050/ with fix for aura_win (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add ash_strings to gyp Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/chrome_browser.gypi ('K') | « chrome/chrome_browser.gypi ('k') | chrome/tools/build/repack_locales.py » ('j') | chrome/tools/build/repack_locales.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/chrome_resources.gyp
diff --git a/chrome/chrome_resources.gyp b/chrome/chrome_resources.gyp
index e8b90d77f4e3b86ed8e41b50fc84a8b02b9edd22..645731586d8599104a164cda3ff3e4037ee70ec3 100644
--- a/chrome/chrome_resources.gyp
+++ b/chrome/chrome_resources.gyp
@@ -269,6 +269,8 @@
'chrome_strings',
'platform_locale_settings',
'theme_resources',
+ # TODO(zork): Protect this with if use_aura==1
+ '<(DEPTH)/ash/ash.gyp:ash_strings',
tony 2012/02/07 18:16:00 Should it be protected by use_ash==1? why not do
'<(DEPTH)/content/content_resources.gyp:content_resources',
'<(DEPTH)/net/net.gyp:net_resources',
'<(DEPTH)/ui/base/strings/ui_strings.gyp:ui_strings',
« chrome/chrome_browser.gypi ('K') | « chrome/chrome_browser.gypi ('k') | chrome/tools/build/repack_locales.py » ('j') | chrome/tools/build/repack_locales.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698